Skip to content

Commit 8fae9c2

Browse files
authored
codewhisperer: reduce token infilling suggestions (#3942)
1 parent 2d67e64 commit 8fae9c2

File tree

3 files changed

+2
-20
lines changed

3 files changed

+2
-20
lines changed

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/editor/CodeWhispererEditorUtil.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ import software.aws.toolkits.jetbrains.services.codewhisperer.language.programmi
1616
import software.aws.toolkits.jetbrains.services.codewhisperer.model.CaretContext
1717
import software.aws.toolkits.jetbrains.services.codewhisperer.model.CaretPosition
1818
import software.aws.toolkits.jetbrains.services.codewhisperer.model.FileContextInfo
19-
import software.aws.toolkits.jetbrains.services.codewhisperer.service.CodeWhispererUserGroup
20-
import software.aws.toolkits.jetbrains.services.codewhisperer.service.CodeWhispererUserGroupSettings
2119
import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants
2220
import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants.LEFT_CONTEXT_ON_CURRENT_LINE
2321
import java.awt.Point
@@ -97,8 +95,7 @@ object CodeWhispererEditorUtil {
9795
val rightContextLines = caretContext.rightFileContext.split(Regex("\r?\n"))
9896
val rightContextCurrentLine = if (rightContextLines.isEmpty()) "" else rightContextLines[0]
9997

100-
return CodeWhispererUserGroupSettings.getInstance().getUserGroup() == CodeWhispererUserGroup.RightContext &&
101-
rightContextCurrentLine.isNotEmpty() &&
98+
return rightContextCurrentLine.isNotEmpty() &&
10299
!rightContextCurrentLine.startsWith(" ") &&
103100
rightContextCurrentLine.trim() != ("}")
104101
}

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/service/CodeWhispererUserGroupSettings.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,7 @@ class CodeWhispererUserGroupSettings : PersistentStateComponent<CodeWhispererUse
7878

7979
@VisibleForTesting
8080
fun determineUserGroup(): CodeWhispererUserGroup {
81-
val randomNum = Math.random()
82-
val group = if (randomNum < 1 / 2.0) {
83-
CodeWhispererUserGroup.Control
84-
} else CodeWhispererUserGroup.RightContext
81+
val group = CodeWhispererUserGroup.Control
8582

8683
settings[USER_GROUP_KEY] = group.name
8784
version = AwsToolkit.PLUGIN_VERSION

jetbrains-core/tst/software/aws/toolkits/jetbrains/services/codewhisperer/CodeWhispererUserActionsTest.kt

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
package software.aws.toolkits.jetbrains.services.codewhisperer
55

6-
import com.intellij.codeInsight.codeVision.ui.visibleAreaChanged
76
import com.intellij.openapi.actionSystem.IdeActions.ACTION_EDITOR_DELETE_LINE
87
import com.intellij.openapi.actionSystem.IdeActions.ACTION_EDITOR_DELETE_TO_WORD_START
98
import com.intellij.openapi.actionSystem.IdeActions.ACTION_EDITOR_MOVE_CARET_LEFT_WITH_SELECTION
@@ -13,32 +12,26 @@ import com.intellij.openapi.actionSystem.IdeActions.ACTION_EDITOR_MOVE_LINE_STAR
1312
import com.intellij.openapi.actionSystem.IdeActions.ACTION_EDITOR_SELECT_WORD_AT_CARET
1413
import com.intellij.openapi.actionSystem.IdeActions.ACTION_EDITOR_TEXT_END_WITH_SELECTION
1514
import com.intellij.openapi.actionSystem.IdeActions.ACTION_EDITOR_TEXT_START_WITH_SELECTION
16-
import com.intellij.openapi.application.ApplicationManager
1715
import com.intellij.openapi.command.WriteCommandAction
1816
import com.intellij.openapi.editor.event.VisibleAreaEvent
1917
import com.intellij.openapi.ui.popup.JBPopup
20-
import com.intellij.testFramework.replaceService
2118
import com.intellij.testFramework.runInEdtAndWait
2219
import org.assertj.core.api.Assertions.assertThat
2320
import org.junit.Before
2421
import org.junit.Test
25-
import org.mockito.Mockito.mock
2622
import org.mockito.Mockito.times
2723
import org.mockito.kotlin.any
2824
import org.mockito.kotlin.argumentCaptor
2925
import org.mockito.kotlin.doReturn
3026
import org.mockito.kotlin.mock
3127
import org.mockito.kotlin.timeout
3228
import org.mockito.kotlin.verify
33-
import org.mockito.kotlin.whenever
3429
import software.aws.toolkits.jetbrains.services.codewhisperer.CodeWhispererTestUtil.javaFileName
3530
import software.aws.toolkits.jetbrains.services.codewhisperer.CodeWhispererTestUtil.pythonFileName
3631
import software.aws.toolkits.jetbrains.services.codewhisperer.CodeWhispererTestUtil.pythonTestLeftContext
3732
import software.aws.toolkits.jetbrains.services.codewhisperer.explorer.CodeWhispererExplorerActionManager
3833
import software.aws.toolkits.jetbrains.services.codewhisperer.popup.listeners.CodeWhispererScrollListener
3934
import software.aws.toolkits.jetbrains.services.codewhisperer.service.CodeWhispererInvocationStatus
40-
import software.aws.toolkits.jetbrains.services.codewhisperer.service.CodeWhispererUserGroup
41-
import software.aws.toolkits.jetbrains.services.codewhisperer.service.CodeWhispererUserGroupSettings
4235
import java.awt.Rectangle
4336

4437
class CodeWhispererUserActionsTest : CodeWhispererTestBase() {
@@ -165,11 +158,6 @@ class CodeWhispererUserActionsTest : CodeWhispererTestBase() {
165158
}
166159

167160
private fun testInputSpecialCharWithRightContext(rightContext: String, shouldtrigger: Boolean) {
168-
val userGroupSetting = mock<CodeWhispererUserGroupSettings>()
169-
ApplicationManager.getApplication().replaceService(CodeWhispererUserGroupSettings::class.java, userGroupSetting, disposableRule.disposable)
170-
171-
whenever(userGroupSetting.getUserGroup()).thenReturn(CodeWhispererUserGroup.RightContext)
172-
173161
CodeWhispererExplorerActionManager.getInstance().setAutoEnabled(true)
174162
setFileContext(pythonFileName, "def", rightContext)
175163
projectRule.fixture.type('{')

0 commit comments

Comments
 (0)