SAM CLI 1.85-1.86.1 fails on windows (#3718)

* SAM CLI 1.85-1.86.1 fails on windows

* Modified changeLog

Author: vchikoti1998

.changes/next-release/bugfix-6e280568-d490-406b-a79f-dc02c2263d2e.json

@@ -0,0 +1,4 @@
+{
+  "type" : "bugfix",
+  "description" : "Add error notification to upgrade SAM CLI v1.85-1.86.1 if on windows"
+}

jetbrains-core/src/software/aws/toolkits/jetbrains/core/executables/ExecutableManager.kt

@@ -12,11 +12,13 @@ import com.intellij.openapi.components.service
 import com.intellij.openapi.project.DumbAware
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.startup.StartupActivity
+import com.intellij.openapi.util.SystemInfo
 import com.intellij.util.io.lastModified
 import software.aws.toolkits.core.utils.exists
 import software.aws.toolkits.core.utils.getLogger
 import software.aws.toolkits.core.utils.warn
 import software.aws.toolkits.jetbrains.core.executables.ExecutableInstance.ExecutableWithPath
+import software.aws.toolkits.jetbrains.services.lambda.sam.SamExecutable
 import software.aws.toolkits.resources.message
 import java.nio.file.Path
 import java.nio.file.Paths
@@ -190,6 +192,18 @@ class DefaultExecutableManager : PersistentStateComponent<ExecutableStateList>,
         try {
             (type as? Validatable)?.validate(path)
             determineVersion(type, path, autoResolved)
+        } catch (e: IllegalStateException) {
+            val errorMessage = if (SystemInfo.isWindows && type is SamExecutable) {
+                message("sam.cli.version.upgrade.required.windows") + "\n" + e.asString
+            } else {
+                message("aws.settings.executables.executable_invalid", type.displayName, e.asString)
+            }
+            ExecutableInstance.InvalidExecutable(
+                path,
+                null,
+                autoResolved,
+                errorMessage
+            )
         } catch (e: Exception) {
             val message = message("aws.settings.executables.executable_invalid", type.displayName, e.asString)
             LOG.warn(e) { message }

resources/resources/software/aws/toolkits/resources/MessagesBundle.properties

@@ -1107,6 +1107,7 @@ sam.build.title=SAM build
 sam.cli.version.upgrade.instructions=Learn more about upgrading SAM CLI
 sam.cli.version.upgrade.reason=Learn more about SAM sync improvements...
 sam.cli.version.upgrade.required=Your SAM CLI version is {0} and does not include performance improvements for Sync Serverless Applications. To continue, please upgrade to SAM CLI version {1} or higher.
+sam.cli.version.upgrade.required.windows=If you are on SAM CLI version 1.85, 1.86 or 1.86.1, it has <a href= 'https://github.com/aws/aws-sam-cli/issues/5243'>known issues</a>. Please consider <a href= 'https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/install-sam-cli.html'>re-installing</a> / <a href= 'https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/manage-sam-cli-versions.html#manage-sam-cli-versions-upgrade'>upgrading</a> the latest version.
 sam.cli.version.warning=SAM CLI version
 sam.debug.attach=Attach Debugger
 sam.debug.attach.parent=Attempt Debugger Attachment