Skip to content

Commit 9150d7e

Browse files
committed
fix(amazonqFeatureDev): include defaults for empty string
1 parent 67c231d commit 9150d7e

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/clients/FeatureDevClient.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ class FeatureDevClient(private val project: Project) {
107107
)
108108
}
109109

110-
fun startTaskAssistCodeGeneration(conversationId: String, uploadId: String, userMessage: String, codeGenerationId: UUID, currentCodeGenerationId: UUID?): StartTaskAssistCodeGenerationResponse = bearerClient()
110+
fun startTaskAssistCodeGeneration(conversationId: String, uploadId: String, userMessage: String, codeGenerationId: UUID, currentCodeGenerationId: String?): StartTaskAssistCodeGenerationResponse = bearerClient()
111111
.startTaskAssistCodeGeneration {
112112
request ->
113113
request
@@ -121,7 +121,7 @@ class FeatureDevClient(private val project: Project) {
121121
it
122122
.programmingLanguage { pl -> pl.languageName("javascript") } // This parameter is omitted by featureDev but required in the request
123123
.uploadId(uploadId)
124-
}.codeGenerationId(codeGenerationId.toString()).currentCodeGenerationId(currentCodeGenerationId.toString())
124+
}.codeGenerationId(codeGenerationId.toString()).currentCodeGenerationId(currentCodeGenerationId)
125125
}
126126

127127
fun getTaskAssistCodeGeneration(conversationId: String, codeGenerationId: String): GetTaskAssistCodeGenerationResponse = bearerClient()

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/CodeGenerationState.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ class CodeGenerationState(
5353
var numberOfFilesGenerated: Int? = null
5454
try {
5555
val codeGenerationId = UUID.randomUUID()
56+
57+
5658
val response = config.featureDevService.startTaskAssistCodeGeneration(
5759
conversationId = config.conversationId,
5860
uploadId = uploadId,
@@ -61,6 +63,10 @@ class CodeGenerationState(
6163
currentCodeGenerationId = currentCodeGenerationId
6264
)
6365

66+
if (action.token?.token()?.isCancellationRequested != true) {
67+
this.currentCodeGenerationId = codeGenerationId
68+
}
69+
6470
messenger.sendAnswerPart(
6571
tabId = tabID,
6672
message = message("amazonqFeatureDev.code_generation.generating_code")

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/util/FeatureDevService.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ class FeatureDevService(val proxyClient: FeatureDevClient, val project: Project)
122122
uploadId,
123123
message,
124124
codeGenerationId,
125-
currentCodeGenerationId
125+
currentCodeGenerationId?.toString() ?: "EMPTY_CURRENT_CODE_GENERATION_ID"
126126
)
127127

128128
logger.debug { "$FEATURE_NAME: Started code generation with requestId: ${startCodeGenerationResponse.responseMetadata().requestId()}" }

plugins/amazonq/mynah-ui/src/mynah-ui/ui/main.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ export const createMynahUI = (ideApi: any, featureDevInitEnabled: boolean, codeT
130130
mynahUI.updateStore(tabID, {
131131
loadingChat: true,
132132
promptInputDisabledState: true,
133+
cancelButtonWhenLoading: true,
133134
})
134135
if (message) {
135136
mynahUI.updateLastChatAnswer(tabID, {
@@ -272,6 +273,7 @@ export const createMynahUI = (ideApi: any, featureDevInitEnabled: boolean, codeT
272273
) {
273274
mynahUI.updateStore(tabID, {
274275
loadingChat: true,
276+
cancelButtonWhenLoading: false,
275277
promptInputDisabledState: true,
276278
})
277279

0 commit comments

Comments
 (0)