Skip to content

Commit 942579b

Browse files
author
Viktor Shesternyak
committed
fix(amazonq): /doc remove retry folowup button to make it in synch with vscode plugin
1 parent 83a69b2 commit 942579b

File tree

2 files changed

+16
-65
lines changed

2 files changed

+16
-65
lines changed

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqDoc/controller/DocController.kt

Lines changed: 10 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -376,10 +376,9 @@ class DocController(
376376

377377
else -> {
378378
logger.error { "$FEATURE_NAME: OpenDiff event is received for a conversation that has ${session.sessionState.phase} phase" }
379-
messenger.sendError(
379+
messenger.sendErrorToUser(
380380
tabId = message.tabId,
381381
errMessage = message("amazonqFeatureDev.exception.open_diff_failed"),
382-
retries = 0,
383382
conversationId = session.conversationIdUnsafe
384383
)
385384
}
@@ -478,10 +477,9 @@ class DocController(
478477
)
479478
} catch (err: Exception) {
480479
val message = createUserFacingErrorMessage("Failed to insert code changes: ${err.message}")
481-
messenger.sendError(
480+
messenger.sendErrorToUser(
482481
tabId = tabId,
483482
errMessage = message ?: message("amazonqFeatureDev.exception.insert_code_failed"),
484-
retries = retriesRemaining(session),
485483
conversationId = session?.conversationIdUnsafe
486484
)
487485
}
@@ -559,10 +557,9 @@ class DocController(
559557

560558
when (err) {
561559
is RepoSizeError -> {
562-
messenger.sendError(
560+
messenger.sendErrorToUser(
563561
tabId = tabId,
564562
errMessage = err.message,
565-
retries = retriesRemaining(session),
566563
conversationId = session?.conversationIdUnsafe
567564
)
568565
messenger.sendSystemPrompt(
@@ -578,10 +575,9 @@ class DocController(
578575
}
579576

580577
is ZipFileError -> {
581-
messenger.sendError(
578+
messenger.sendErrorToUser(
582579
tabId = tabId,
583580
errMessage = err.message,
584-
retries = 0,
585581
conversationId = session?.conversationIdUnsafe
586582
)
587583
}
@@ -673,10 +669,9 @@ class DocController(
673669
else -> message("amazonqFeatureDev.error_text")
674670
}
675671

676-
messenger.sendError(
672+
messenger.sendErrorToUser(
677673
tabId = tabId,
678674
errMessage = defaultMessage,
679-
retries = retriesRemaining(session),
680675
conversationId = session?.conversationIdUnsafe
681676
)
682677
}
@@ -773,9 +768,12 @@ class DocController(
773768
) {
774769
return
775770
}
776-
777771
if (filePaths.isEmpty() && deletedFiles.isEmpty()) {
778-
handleEmptyFiles(followUpMessage, session)
772+
messenger.sendErrorToUser(
773+
followUpMessage.tabId,
774+
message("amazonqDoc.error.generating"),
775+
conversationId = session.conversationId
776+
)
779777
return
780778
}
781779

@@ -830,37 +828,6 @@ class DocController(
830828
}
831829
}
832830

833-
private suspend fun handleEmptyFiles(
834-
message: IncomingDocMessage.FollowupClicked,
835-
session: DocSession,
836-
) {
837-
messenger.sendAnswer(
838-
message = message("amazonqDoc.error.generating"),
839-
messageType = DocMessageType.Answer,
840-
tabId = message.tabId,
841-
canBeVoted = true
842-
)
843-
844-
messenger.sendAnswer(
845-
messageType = DocMessageType.SystemPrompt,
846-
tabId = message.tabId,
847-
followUp = if (retriesRemaining(session) > 0) {
848-
listOf(
849-
FollowUp(
850-
pillText = message("amazonqFeatureDev.follow_up.retry"),
851-
type = FollowUpTypes.RETRY,
852-
status = FollowUpStatusType.Warning
853-
)
854-
)
855-
} else {
856-
emptyList()
857-
}
858-
)
859-
860-
// Lock the chat input until they explicitly click retry
861-
messenger.sendChatInputEnabledMessage(tabId = message.tabId, enabled = false)
862-
}
863-
864831
private suspend fun retryRequests(tabId: String) {
865832
var session: DocSession? = null
866833
docGenerationTask = DocGenerationTask()

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqDoc/controller/DocControllerExtensions.kt

Lines changed: 6 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,11 @@ package software.aws.toolkits.jetbrains.services.amazonqDoc.controller
66
import com.intellij.notification.NotificationAction
77
import software.aws.toolkits.jetbrains.services.amazonqDoc.inProgress
88
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.DocMessageType
9-
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.FollowUp
10-
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.FollowUpStatusType
11-
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.FollowUpTypes
129
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.sendAnswer
1310
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.sendAsyncEventProgress
1411
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.sendChatInputEnabledMessage
1512
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.sendCodeResult
13+
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.sendErrorToUser
1614
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.sendSystemPrompt
1715
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.sendUpdatePlaceholder
1816
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.sendUpdatePromptProgress
@@ -73,26 +71,12 @@ suspend fun DocController.onCodeGeneration(session: DocSession, message: String,
7371

7472
// Atm this is the only possible path as codegen is mocked to return empty.
7573
if (filePaths.size or deletedFiles.size == 0) {
76-
messenger.sendAnswer(
77-
tabId = tabId,
78-
messageType = DocMessageType.Answer,
79-
message = message("amazonqFeatureDev.code_generation.no_file_changes")
80-
)
81-
messenger.sendSystemPrompt(
82-
tabId = tabId,
83-
followUp = if (retriesRemaining(session) > 0) {
84-
listOf(
85-
FollowUp(
86-
pillText = message("amazonqFeatureDev.follow_up.retry"),
87-
type = FollowUpTypes.RETRY,
88-
status = FollowUpStatusType.Warning
89-
)
90-
)
91-
} else {
92-
emptyList()
93-
}
74+
messenger.sendErrorToUser(
75+
tabId,
76+
message("amazonqDoc.error.generating"),
77+
conversationId = session.conversationId
9478
)
95-
messenger.sendChatInputEnabledMessage(tabId = tabId, enabled = false) // Lock chat input until retry is clicked.
79+
9680
return
9781
}
9882

0 commit comments

Comments
 (0)