Skip to content

Commit 94a7001

Browse files
authored
Fix IDE issues with gateway/rider/ultimate (#3563)
1 parent 323ebee commit 94a7001

File tree

4 files changed

+17
-11
lines changed

4 files changed

+17
-11
lines changed

buildSrc/src/main/kotlin/toolkit-integration-testing.gradle.kts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ sourceSets {
1818
}
1919
}
2020

21-
configurations.getByName("integrationTestImplementation") {
22-
extendsFrom(configurations.getByName(JavaPlugin.TEST_IMPLEMENTATION_CONFIGURATION_NAME))
21+
configurations.getByName("integrationTestCompileClasspath") {
22+
extendsFrom(configurations.getByName(JavaPlugin.TEST_COMPILE_CLASSPATH_CONFIGURATION_NAME))
2323
isCanBeResolved = true
2424
}
25-
configurations.getByName("integrationTestRuntimeOnly") {
26-
extendsFrom(configurations.getByName(JavaPlugin.TEST_RUNTIME_ONLY_CONFIGURATION_NAME))
25+
configurations.getByName("integrationTestRuntimeClasspath") {
26+
extendsFrom(configurations.getByName(JavaPlugin.TEST_RUNTIME_CLASSPATH_CONFIGURATION_NAME))
2727
isCanBeResolved = true
2828
}
2929

jetbrains-gateway/build.gradle.kts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,13 @@ val gatewayRunOnly by configurations.creating {
2121
}
2222

2323
dependencies {
24-
// pull in :j-c:instrumentedJar for compile and :intellij:buildPlugin, but gateway variant when runIde/buildPlugin from :jetbrains-gateway
25-
compileOnly(project(":jetbrains-core", "instrumentedJar"))
24+
// link against :j-c: and rely on :intellij:buildPlugin to pull in :j-c:instrumentedJar, but gateway variant when runIde/buildPlugin from :jetbrains-gateway
25+
compileOnly(project(":jetbrains-core"))
2626
gatewayRunOnly(project(":jetbrains-core", "gatewayArtifacts"))
2727

2828
testImplementation(project(path = ":core", configuration = "testArtifacts"))
29-
testImplementation(project(":jetbrains-core", "gatewayArtifacts"))
29+
testCompileOnly(project(":jetbrains-core"))
30+
testRuntimeOnly(project(":jetbrains-core", "gatewayArtifacts"))
3031
testImplementation(project(path = ":jetbrains-core", configuration = "testArtifacts"))
3132
testImplementation(libs.wiremock)
3233
testImplementation(libs.bundles.sshd)

jetbrains-rider/build.gradle.kts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,11 @@ sourceSets {
5050
}
5151

5252
dependencies {
53-
implementation(project(":jetbrains-core", "instrumentedJar"))
53+
compileOnly(project(":jetbrains-core"))
54+
runtimeOnly(project(":jetbrains-core", "instrumentedJar"))
55+
56+
testCompileOnly(project(":jetbrains-core"))
57+
testRuntimeOnly(project(":jetbrains-core", "instrumentedJar"))
5458
testImplementation(project(path = ":jetbrains-core", configuration = "testArtifacts"))
5559
}
5660

jetbrains-ultimate/build.gradle.kts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,14 @@ plugins {
1111
}
1212

1313
dependencies {
14-
api(project(":jetbrains-core", "instrumentedJar"))
14+
compileOnly(project(":jetbrains-core"))
15+
runtimeOnly(project(":jetbrains-core", "instrumentedJar"))
1516

17+
testCompileOnly(project(":jetbrains-core"))
18+
testRuntimeOnly(project(":jetbrains-core", "instrumentedJar"))
1619
testImplementation(project(path = ":jetbrains-core", configuration = "testArtifacts"))
1720
testImplementation(project(path = ":core", configuration = "testArtifacts"))
1821
testImplementation(libs.mockk)
19-
20-
integrationTestImplementation(project(path = ":jetbrains-core", configuration = "testArtifacts"))
2122
}
2223

2324
intellijToolkit {

0 commit comments

Comments
 (0)