Match DDB index names agianst regex (#2710)

Author: abrooksv

jetbrains-core/src/software/aws/toolkits/jetbrains/services/dynamodb/editor/DynamoDbTableEditor.kt

@@ -18,6 +18,7 @@ import software.amazon.awssdk.services.dynamodb.model.ExecuteStatementRequest
 import software.amazon.awssdk.services.dynamodb.model.KeySchemaElement
 import software.amazon.awssdk.services.dynamodb.model.KeyType
 import software.aws.toolkits.core.utils.debug
+import software.aws.toolkits.core.utils.error
 import software.aws.toolkits.core.utils.getLogger
 import software.aws.toolkits.jetbrains.services.dynamodb.DynamoDbUtils.executeStatementPaginator
 import software.aws.toolkits.jetbrains.services.dynamodb.Index
@@ -130,6 +131,7 @@ class DynamoDbTableEditor(private val dynamoTable: DynamoDbVirtualFile) : UserDa
                         searchResults.setBusy(false)
                     }
                 } catch (e: Exception) {
+                    LOG.error(e) { "Query failed to execute" }
                     withContext(edt) {
                         searchResults.setError(e)
                         searchResults.setBusy(false)

jetbrains-core/src/software/aws/toolkits/jetbrains/services/dynamodb/editor/SearchPanel.kt

@@ -39,14 +39,27 @@ class SearchPanel(private val tableInfo: TableInfo, initialSearchType: SearchTyp
         decorator.setContentComponent(queryScanPanel)
     }
 
+    fun getComponent() = panel
+
     fun getSearchQuery(): Pair<Index, String> {
         queryScanPanel.apply()
 
-        return searchIndex to buildString {
-            append("""SELECT * FROM "${tableInfo.tableName}"""")
+        val fromField = buildString {
+            append('"')
+            append(verifyString(tableInfo.tableName))
+            append('"')
+
             searchIndex.indexName?.let {
-                append("""."$it"""")
+                append('.')
+                append('"')
+                append(verifyString(it))
+                append('"')
             }
+        }
+
+        return searchIndex to buildString {
+            append("SELECT * FROM ")
+            append(fromField)
 
             if (searchType == SearchType.Query) {
                 append(" WHERE ")
@@ -55,5 +68,12 @@ class SearchPanel(private val tableInfo: TableInfo, initialSearchType: SearchTyp
         }
     }
 
-    fun getComponent() = panel
+    private fun verifyString(str: String): String = str.takeIf {
+        str.matches(NAMING_RULES)
+    } ?: throw IllegalArgumentException("'$str' does not match $NAMING_RULES")
+
+    private companion object {
+        // https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/HowItWorks.NamingRulesDataTypes.html#HowItWorks.NamingRules
+        private val NAMING_RULES = """^[A-Za-z0-9_\-.]+${'$'}""".toRegex()
+    }
 }