Skip to content

Commit 9533511

Browse files
authored
Provided correct doc links in Add connection dialog box (#3616)
* Provided correct doc links in Add connection dialog box * Addressed PR comment * Added a test for builderId doc * reverted changes
1 parent 9709afb commit 9533511

File tree

4 files changed

+30
-2
lines changed

4 files changed

+30
-2
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type" : "bugfix",
3+
"description" : "Fix the Add Connection Dialog box references to the correct documentation pages"
4+
}

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/util/CodeWhispererConstants.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ object CodeWhispererConstants {
3434
const val CODEWHISPERER_LEARN_MORE_URI = "https://aws.amazon.com/codewhisperer"
3535
const val CODEWHISPERER_SSO_LEARN_MORE_URI = "https://docs.aws.amazon.com/toolkit-for-jetbrains/latest/userguide/codewhisperer-auth.html"
3636
const val CODEWHISPERER_LOGIN_LEARN_MORE_URI = "https://docs.aws.amazon.com/toolkit-for-jetbrains/latest/userguide/codewhisper-setup-general.html"
37-
const val CODEWHISPERER_LOGIN_HELP_URI = "https://docs.aws.amazon.com/toolkit-for-jetbrains/latest/userguide/codewhisperer.html"
37+
const val CODEWHISPERER_LOGIN_HELP_URI = "https://docs.aws.amazon.com/toolkit-for-jetbrains/latest/userguide/setup-credentials.html"
3838

3939
const val THROTTLING_MESSAGE = "Maximum recommendation count reached for this month."
4040

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
// Copyright 2023 Amazon.com, Inc. or its affiliates. All Rights Reserved.
2+
// SPDX-License-Identifier: Apache-2.0
3+
4+
package software.aws.toolkits.jetbrains.services.codewhisperer
5+
6+
import com.intellij.help.impl.HelpManagerImpl
7+
import com.intellij.openapi.help.HelpManager
8+
import com.intellij.testFramework.ApplicationRule
9+
import org.assertj.core.api.Assertions.assertThat
10+
import org.junit.Rule
11+
import org.junit.Test
12+
import software.aws.toolkits.jetbrains.core.help.HelpIds
13+
class CodeWhispererConstantsTest {
14+
15+
@Rule
16+
@JvmField
17+
val application = ApplicationRule()
18+
19+
@Test
20+
fun `is codewishperer help uri has correct doc link`() {
21+
assertThat((HelpManager.getInstance() as HelpManagerImpl).getHelpUrl(HelpIds.CODEWHISPERER_LOGIN_YES_NO.id))
22+
.isEqualTo("https://docs.aws.amazon.com/toolkit-for-jetbrains/latest/userguide/setup-credentials.html")
23+
}
24+
}

resources/resources/software/aws/toolkits/resources/MessagesBundle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1428,7 +1428,7 @@ toolkit.login.aws_builder_id.already_connected.cancel=Use existing AWS Builder I
14281428
toolkit.login.aws_builder_id.already_connected.message=You already signed in with an AWS Builder ID.\nSign out to add another?
14291429
toolkit.login.aws_builder_id.already_connected.reconnect=Sign out
14301430
toolkit.login.aws_builder_id.already_connected.title=Sign out of current AWS Builder ID?
1431-
toolkit.login.dialog.aws_builder_id.comment=AWS Builder ID is a new personal profile for builders. <a href='https://docs.aws.amazon.com/toolkit-for-jetbrains/latest/userguide/codewhisperer.html'>Learn More</a>
1431+
toolkit.login.dialog.aws_builder_id.comment=AWS Builder ID is a new personal profile for builders. <a href='https://docs.aws.amazon.com/toolkit-for-jetbrains/latest/userguide/builder-id.html'>Learn More</a>
14321432
toolkit.login.dialog.aws_builder_id.title=Use a personal email to sign up and sign in with AWS Builder ID
14331433
toolkit.login.dialog.connect_button=Connect
14341434
toolkit.login.dialog.connect_inprogress=Waiting to Authenticate...

0 commit comments

Comments
 (0)