Skip to content

Commit 9bedaee

Browse files
authored
Classifier trigger rollout for 5 languages (#3708)
1 parent b6ed685 commit 9bedaee

File tree

7 files changed

+15
-11
lines changed

7 files changed

+15
-11
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type" : "feature",
3+
"description" : "CodeWhisperer improves auto-suggestions for python csharp typescript and javascript"
4+
}

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/language/languages/CodeWhispererCsharp.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ class CodeWhispererCsharp private constructor() : CodeWhispererProgrammingLangua
1515

1616
override fun isClassifierSupported(): Boolean = true
1717

18+
override fun isAllClassifier(): Boolean = true
19+
1820
companion object {
1921
const val ID = "csharp"
2022

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/language/languages/CodeWhispererJavaScript.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ class CodeWhispererJavaScript private constructor() : CodeWhispererProgrammingLa
1717

1818
override fun isClassifierSupported(): Boolean = true
1919

20+
override fun isAllClassifier(): Boolean = true
21+
2022
companion object {
2123
const val ID = "javascript"
2224

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/language/languages/CodeWhispererPython.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ class CodeWhispererPython private constructor() : CodeWhispererProgrammingLangua
1919

2020
override fun isClassifierSupported(): Boolean = true
2121

22+
override fun isAllClassifier(): Boolean = true
23+
2224
companion object {
2325
const val ID = "python"
2426

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/language/languages/CodeWhispererTypeScript.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ class CodeWhispererTypeScript private constructor() : CodeWhispererProgrammingLa
1515

1616
override fun isClassifierSupported(): Boolean = true
1717

18+
override fun isAllClassifier(): Boolean = true
19+
1820
companion object {
1921
const val ID = "typescript"
2022

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/service/CodeWhispererAutoTriggerService.kt

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ import kotlinx.coroutines.launch
1919
import org.apache.commons.collections4.queue.CircularFifoQueue
2020
import software.aws.toolkits.jetbrains.core.coroutines.applicationCoroutineScope
2121
import software.aws.toolkits.jetbrains.services.codewhisperer.editor.CodeWhispererEditorUtil
22-
import software.aws.toolkits.jetbrains.services.codewhisperer.language.CodeWhispererProgrammingLanguage
23-
import software.aws.toolkits.jetbrains.services.codewhisperer.language.languages.CodeWhispererJava
2422
import software.aws.toolkits.jetbrains.services.codewhisperer.language.languages.CodeWhispererUnknownLanguage
2523
import software.aws.toolkits.jetbrains.services.codewhisperer.language.programmingLanguage
2624
import software.aws.toolkits.jetbrains.services.codewhisperer.model.LatencyContext
@@ -247,24 +245,18 @@ class CodeWhispererAutoTriggerService : CodeWhispererAutoTriggerHandler, Disposa
247245
previousOneOther +
248246
CodeWhispererClassifierConstants.intercept
249247

250-
val shouldTrigger = sigmoid(resultBeforeSigmoid) > getThreshold(language)
248+
val shouldTrigger = sigmoid(resultBeforeSigmoid) > getThreshold()
251249
return ClassifierResult(shouldTrigger, sigmoid(resultBeforeSigmoid))
252250
}
253251

254252
override fun dispose() {}
255253

256254
companion object {
257255
private const val triggerThreshold: Double = 0.4
258-
private const val expTriggerThreshold: Double = 0.35
259256

260257
fun getInstance(): CodeWhispererAutoTriggerService = service()
261258

262-
fun getThreshold(language: CodeWhispererProgrammingLanguage): Double =
263-
if (language is CodeWhispererJava && CodeWhispererUserGroupSettings.getInstance().isExpThreshold()) {
264-
expTriggerThreshold
265-
} else {
266-
triggerThreshold
267-
}
259+
fun getThreshold(): Double = triggerThreshold
268260

269261
fun sigmoid(x: Double): Double = 1 / (1 + exp(-x))
270262
}

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererTelemetryService.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ class CodeWhispererTelemetryService {
198198
}
199199

200200
val classifierThreshold = if (shouldIncludeClassifier) {
201-
CodeWhispererAutoTriggerService.getThreshold(language)
201+
CodeWhispererAutoTriggerService.getThreshold()
202202
} else {
203203
null
204204
}

0 commit comments

Comments
 (0)