Improve error logging for sign-in dialog (#3550)

Author: rli

jetbrains-core/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAddConnectionDialog.kt

@@ -38,6 +38,7 @@ import software.aws.toolkits.jetbrains.core.credentials.sono.SONO_URL
 import software.aws.toolkits.jetbrains.core.help.HelpIds
 import software.aws.toolkits.resources.message
 import software.aws.toolkits.telemetry.UiTelemetry
+import java.io.IOException
 import javax.swing.JComponent
 
 data class ConnectionDialogCustomizer(
@@ -117,7 +118,7 @@ open class ToolkitAddConnectionDialog(
             try {
                 // Edge case when user choose SSO but enter AWS Builder ID url
                 if (loginType == LoginOptions.SSO && startUrl == SONO_URL) {
-                    error("User should not do SSO login with AWS Builder ID url")
+                    error("User should not perform Identity Center login with AWS Builder ID url")
                 }
 
                 val scopes = if (loginType == LoginOptions.AWS_BUILDER_ID) {
@@ -133,11 +134,19 @@ open class ToolkitAddConnectionDialog(
                 }
             } catch (e: Exception) {
                 val message = when (e) {
+                    is IllegalStateException -> e.message ?: message("general.unknown_error")
                     is ProcessCanceledException -> message("codewhisperer.credential.login.dialog.exception.cancel_login")
                     is InvalidGrantException -> message("codewhisperer.credential.login.exception.invalid_grant")
                     is InvalidRequestException -> message("codewhisperer.credential.login.exception.invalid_input")
                     is SsoOidcException -> message("codewhisperer.credential.login.exception.general.oidc")
-                    else -> message("codewhisperer.credential.login.exception.general")
+                    else -> {
+                        val baseMessage = when (e) {
+                            is IOException -> "codewhisperer.credential.login.exception.io"
+                            else -> "codewhisperer.credential.login.exception.general"
+                        }
+
+                        message(baseMessage, "${e.javaClass.name}: ${e.message}")
+                    }
                 }
                 LOG.warn(e) { message }
                 setErrorText(message)

resources/resources/software/aws/toolkits/resources/MessagesBundle.properties

@@ -436,10 +436,11 @@ codewhisperer.credential.login.dialog.iam.description=Not supported by CodeWhisp
 codewhisperer.credential.login.dialog.ok_button=Connect
 codewhisperer.credential.login.dialog.prompt=Select a connection option to start using CodeWhisperer
 codewhisperer.credential.login.dialog.title=CodeWhisperer: Add Connection to AWS
-codewhisperer.credential.login.exception.general=Run into unknown error
+codewhisperer.credential.login.exception.general=Ran into unknown error: {0}
 codewhisperer.credential.login.exception.general.oidc=Fail to fetch credential
 codewhisperer.credential.login.exception.invalid_grant=Access denied
 codewhisperer.credential.login.exception.invalid_input=Invalid start url
+codewhisperer.credential.login.exception.io=Unable to access SSO disk cache: {0}
 codewhisperer.credential.login.prompt.sono.message=Sign in with AWS Builder ID
 codewhisperer.credential.login.prompt.sono.title=AWS Builder ID login
 codewhisperer.experiment=CodeWhisperer