Removing usage of validating panel (#3857)

* removed validating panel

* removed validating panel

* removed validating panel

* input validation

* input validation

* fixed tests

* fixed detekt

Author: manodnyab

jetbrains-core/src/software/aws/toolkits/jetbrains/core/tools/ToolConfigurable.kt

@@ -7,57 +7,45 @@ import com.intellij.openapi.fileChooser.FileChooserDescriptorFactory
 import com.intellij.openapi.options.BoundConfigurable
 import com.intellij.openapi.options.SearchableConfigurable
 import com.intellij.openapi.ui.emptyText
-import com.intellij.openapi.util.ClearableLazyValue
 import com.intellij.ui.components.JBTextField
 import com.intellij.ui.dsl.builder.Align
 import com.intellij.ui.dsl.builder.bindText
 import com.intellij.ui.dsl.builder.panel
 import com.intellij.ui.layout.applyToComponent
-import software.aws.toolkits.jetbrains.ui.ValidatingPanel
 import software.aws.toolkits.resources.message
 import java.nio.file.Path
 
 class ToolConfigurable : BoundConfigurable(message("executableCommon.configurable.title")), SearchableConfigurable {
     private val settings = ToolSettings.getInstance()
     private val manager = ToolManager.getInstance()
-    private val panel = ClearableLazyValue.create {
-        ValidatingPanel(
-            disposable ?: throw RuntimeException("Should never happen as `createPanel` is called after disposable is assigned"),
-            checkContinuously = false,
-            contentPanel = panel {
-                ToolType.EP_NAME.extensionList.forEach { toolType ->
-                    row(toolType.displayName) {
-                        textFieldWithBrowseButton(fileChooserDescriptor = FileChooserDescriptorFactory.createSingleFileDescriptor())
-                            .bindText(
-                                { settings.getExecutablePath(toolType) ?: "" },
-                                { settings.setExecutablePath(toolType, it.takeIf { v -> v.isNotBlank() }) }
-                            )
-                            .validationOnApply {
-                                it.textField.text.takeIf { t -> t.isNotBlank() }?.let { path ->
-                                    manager.validateCompatability(Path.of(path), toolType).toValidationInfo(toolType, component)
-                                }
-                            }.applyToComponent {
-                                setEmptyText(toolType, textField as JBTextField)
-                            }.resizableColumn()
-                            .align(Align.FILL)
-
-                        browserLink(message("aws.settings.learn_more"), toolType.documentationUrl())
-                    }
+    private val panel by lazy {
+        panel {
+            ToolType.EP_NAME.extensionList.forEach { toolType ->
+                row(toolType.displayName) {
+                    textFieldWithBrowseButton(fileChooserDescriptor = FileChooserDescriptorFactory.createSingleFileDescriptor())
+                        .bindText(
+                            { settings.getExecutablePath(toolType) ?: "" },
+                            { settings.setExecutablePath(toolType, it.takeIf { v -> v.isNotBlank() }) }
+                        )
+                        .validationOnInput {
+                            it.textField.text.takeIf { t -> t.isNotBlank() }?.let { path ->
+                                manager.validateCompatability(Path.of(path), toolType).toValidationInfo(toolType, component)
+                            }
+                        }.applyToComponent {
+                            setEmptyText(toolType, textField as JBTextField)
+                        }.resizableColumn()
+                        .align(Align.FILL)
+
+                    browserLink(message("aws.settings.learn_more"), toolType.documentationUrl())
                 }
-            },
-            emptyMap()
-        )
+            }
+        }
     }
 
-    override fun createPanel() = panel.value.contentPanel
+    override fun createPanel() = panel
 
     override fun apply() {
-        panel.value.apply()
-    }
-
-    override fun disposeUIResources() {
-        // TODO: why are we overriding and not allowing the disposable to be disposed?
-        panel.drop()
+        panel.apply()
     }
 
     override fun getId(): String = "aws.tools"

jetbrains-core/src/software/aws/toolkits/jetbrains/ui/CredentialIdentifierSelector.kt

@@ -83,7 +83,7 @@ class CredentialIdentifierSelector(identifiers: List<CredentialIdentifier> = Cre
      */
     fun getSelectedValidCredentialIdentifier(): CredentialIdentifier? = comboBoxModel.selected?.takeIf { isSelectionValid() }
 
-    private class InvalidCredentialIdentifier(override val id: String) : CredentialIdentifier {
+    class InvalidCredentialIdentifier(override val id: String) : CredentialIdentifier {
         override val displayName: String = message("credentials.invalid.not_found", id)
         override val factoryId: String = "InvalidCredentialIdentifier"
         override val credentialType: CredentialType? = null
@@ -120,7 +120,7 @@ class CredentialIdentifierSelector(identifiers: List<CredentialIdentifier> = Cre
                 .withValidationOnInput { validateSelection(it) }
         }
 
-        private fun ValidationInfoBuilder.validateSelection(selector: CredentialIdentifierSelector): ValidationInfo? = if (!selector.isSelectionValid()) {
+        fun ValidationInfoBuilder.validateSelection(selector: CredentialIdentifierSelector): ValidationInfo? = if (!selector.isSelectionValid()) {
             error(message("credentials.invalid.invalid_selection"))
         } else {
             null