Fix cloudwatch logs open existing tab (#3260)

* revert changes

* fixed edt issues

* detekt changes

* test

* fixed test

* Remove unused parameters

* remove spaces

* added changelog

Author: manodnyab

.changes/next-release/bugfix-0c056100-04bf-4c38-bbe4-0d8f5cdaae0c.json

@@ -0,0 +1,4 @@
+{
+  "type" : "bugfix",
+  "description" : "Fix opening toolwindow tabs in incorrect thread in Cloudwatch Logs"
+}

jetbrains-core/src/software/aws/toolkits/jetbrains/core/toolwindow/ToolkitToolWindow.kt

@@ -70,8 +70,11 @@ interface ToolkitToolWindow {
 
         val content = find(id)
         if (content != null) {
-            toolWindow.activate(null, true)
-            toolWindow.contentManager.setSelectedContent(content)
+            runInEdt {
+                toolWindow.activate(null, true)
+                toolWindow.contentManager.setSelectedContent(content)
+            }
+
             return true
         }
 

jetbrains-core/src/software/aws/toolkits/jetbrains/services/cloudwatch/logs/insights/DetailedLogRecord.kt

@@ -4,6 +4,7 @@
 package software.aws.toolkits.jetbrains.services.cloudwatch.logs.insights
 
 import com.intellij.openapi.Disposable
+import com.intellij.openapi.application.runInEdt
 import com.intellij.openapi.project.Project
 import com.intellij.ui.TableSpeedSearch
 import com.intellij.ui.components.breadcrumbs.Breadcrumbs
@@ -61,8 +62,11 @@ class DetailedLogRecord(
         coroutineScope.launch {
             val record = recordLoadTask.await()
             val items = record.map { it.key to it.value }
-            tableView.listTableModel.items = items
-            tableView.setPaintBusy(false)
+
+            runInEdt {
+                tableView.listTableModel.items = items
+                tableView.setPaintBusy(false)
+            }
 
             if (items.isNotEmpty()) {
                 val logGroup = record["@log"] ?: return@launch

jetbrains-core/tst/software/aws/toolkits/jetbrains/services/cloudwatch/logs/insights/DetailedLogRecordTest.kt

@@ -5,7 +5,6 @@ package software.aws.toolkits.jetbrains.services.cloudwatch.logs.insights
 
 import com.intellij.testFramework.EdtRule
 import com.intellij.testFramework.RuleChain
-import com.intellij.testFramework.RunsInEdt
 import kotlinx.coroutines.delay
 import kotlinx.coroutines.runBlocking
 import org.assertj.core.api.Assertions.assertThat
@@ -23,7 +22,6 @@ import software.aws.toolkits.jetbrains.core.MockClientManagerRule
 import software.aws.toolkits.jetbrains.utils.rules.JavaCodeInsightTestFixtureRule
 import software.aws.toolkits.jetbrains.utils.waitForModelToBeAtLeast
 
-@RunsInEdt
 class DetailedLogRecordTest {
     val projectRule = JavaCodeInsightTestFixtureRule()
 
@@ -50,6 +48,7 @@ class DetailedLogRecordTest {
             )
         val sut = DetailedLogRecord(projectRule.project, client, "ptr")
         val model = sut.tableView.listTableModel
+
         runBlocking {
             model.waitForModelToBeAtLeast(1)
         }