Add warning to indicate time delay in SQS queue deletion (#3141)

Author: manodnyab

.changes/next-release/feature-d3d53767-b69d-4464-bf8c-c62875cfedae.json

@@ -0,0 +1,4 @@
+{
+  "type" : "feature",
+  "description" : "Add warning to indicate time delay in SQS queue deletion"
+}

jetbrains-core/src/software/aws/toolkits/jetbrains/core/explorer/DeleteResourceDialog.kt

@@ -6,6 +6,7 @@ package software.aws.toolkits.jetbrains.core.explorer
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.ui.DialogWrapper
 import com.intellij.openapi.ui.Messages
+import com.intellij.openapi.ui.panel.ComponentPanelBuilder
 import com.intellij.ui.DocumentAdapter
 import com.intellij.ui.components.JBLabel
 import com.intellij.ui.components.JBTextField
@@ -17,7 +18,8 @@ import javax.swing.event.DocumentEvent
 class DeleteResourceDialog(
     project: Project,
     private val resourceType: String,
-    private val resourceName: String
+    private val resourceName: String,
+    private val comment: String = ""
 ) : DialogWrapper(project) {
     private val deleteResourceConfirmation = JBTextField().apply {
         emptyText.text = message("delete_resource.confirmation_text")
@@ -33,6 +35,14 @@ class DeleteResourceDialog(
             row {
                 deleteResourceConfirmation(grow)
             }
+            createNoteOrCommentRow(
+                ComponentPanelBuilder.createCommentComponent(
+                    comment,
+                    true,
+                    -1,
+                    true
+                )
+            ).visible = !comment.isNullOrEmpty()
         }
     }
 

jetbrains-core/src/software/aws/toolkits/jetbrains/core/explorer/actions/DeleteResourceAction.kt

@@ -20,10 +20,12 @@ abstract class DeleteResourceAction<in T : AwsExplorerResourceNode<*>> : SingleR
     constructor() : super()
     constructor(text: String) : super(text, icon = AllIcons.Actions.Cancel)
 
+    open val comment: String = ""
+
     final override fun actionPerformed(selected: T, e: AnActionEvent) {
         val resourceType = selected.resourceType()
         val resourceName = selected.displayName()
-        val response = DeleteResourceDialog(selected.nodeProject, resourceType, resourceName).showAndGet()
+        val response = DeleteResourceDialog(selected.nodeProject, resourceType, resourceName, comment).showAndGet()
         if (!response) {
             AwsTelemetry.deleteResource(selected.project, selected.serviceId, Result.Cancelled)
         } else {

jetbrains-core/src/software/aws/toolkits/jetbrains/services/sqs/actions/DeleteQueueAction.kt

@@ -23,4 +23,6 @@ class DeleteQueueAction : DeleteResourceAction<SqsQueueNode>(message("sqs.delete
         client.deleteQueue { it.queueUrl(selected.queueUrl) }
         project.refreshAwsTree(SqsResources.LIST_QUEUE_URLS)
     }
+
+    override val comment: String = message("resource.delete.warning_text", "queue")
 }

resources/resources/software/aws/toolkits/resources/MessagesBundle.properties

@@ -838,6 +838,7 @@ redshift.validation.invalid_credential_specified=Invalid credential profile {0}
 redshift.validation.invalid_region_specified=Invalid region {0} selected!
 redshift.validation.no_cluster_id=No cluster ID specified!
 redshift.validation.username=A non-empty username is required
+resource.delete.warning_text=Deletion of the {0} may take more than a minute to be reflected
 run_configuration_extension.currently_selected=Use the currently selected credential profile/region
 run_configuration_extension.feature.java.description=Allow injecting AWS Credentials via Environment Variables into some Java-based Run Configurations
 run_configuration_extension.feature.java.title=AWS connected Java Run Configurations