Skip to content

Commit a81caf6

Browse files
authored
Add accetpedCharCount into UserTriggerDecision STE (#5008)
* Add accetpedCharCount into UserTriggerDecision STE * detekt * test fix
1 parent 41965f8 commit a81caf6

File tree

5 files changed

+17
-5
lines changed

5 files changed

+17
-5
lines changed

plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/credentials/CodeWhispererClientAdaptor.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ interface CodeWhispererClientAdaptor : Disposable {
9696
suggestionReferenceCount: Int,
9797
lineCount: Int,
9898
numberOfRecommendations: Int,
99+
acceptedCharCount: Int,
99100
): SendTelemetryEventResponse
100101

101102
fun sendUserTriggerDecisionTelemetry(
@@ -107,6 +108,7 @@ interface CodeWhispererClientAdaptor : Disposable {
107108
suggestionReferenceCount: Int,
108109
lineCount: Int,
109110
numberOfRecommendations: Int,
111+
acceptedCharCount: Int,
110112
): SendTelemetryEventResponse
111113

112114
fun sendCodePercentageTelemetry(
@@ -291,6 +293,7 @@ open class CodeWhispererClientAdaptorImpl(override val project: Project) : CodeW
291293
suggestionReferenceCount: Int,
292294
lineCount: Int,
293295
numberOfRecommendations: Int,
296+
acceptedCharCount: Int,
294297
): SendTelemetryEventResponse {
295298
val fileContext = requestContext.fileContextInfo
296299
val programmingLanguage = fileContext.programmingLanguage
@@ -322,6 +325,7 @@ open class CodeWhispererClientAdaptorImpl(override val project: Project) : CodeW
322325
it.generatedLine(lineCount)
323326
it.customizationArn(requestContext.customizationArn)
324327
it.numberOfRecommendations(numberOfRecommendations)
328+
it.acceptedCharacterCount(acceptedCharCount)
325329
}
326330
}
327331
requestBuilder.optOutPreference(getTelemetryOptOutPreference())
@@ -338,6 +342,7 @@ open class CodeWhispererClientAdaptorImpl(override val project: Project) : CodeW
338342
suggestionReferenceCount: Int,
339343
lineCount: Int,
340344
numberOfRecommendations: Int,
345+
acceptedCharCount: Int,
341346
): SendTelemetryEventResponse {
342347
val fileContext = requestContext.fileContextInfo
343348
val programmingLanguage = fileContext.programmingLanguage
@@ -365,6 +370,7 @@ open class CodeWhispererClientAdaptorImpl(override val project: Project) : CodeW
365370
it.generatedLine(lineCount)
366371
it.customizationArn(requestContext.customizationArn)
367372
it.numberOfRecommendations(numberOfRecommendations)
373+
it.acceptedCharacterCount(acceptedCharCount)
368374
}
369375
}
370376
requestBuilder.optOutPreference(getTelemetryOptOutPreference())

plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererTelemetryService.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,8 @@ class CodeWhispererTelemetryService {
228228
suggestionState,
229229
suggestionReferenceCount,
230230
generatedLineCount,
231-
recommendationContext.details.size
231+
recommendationContext.details.size,
232+
acceptedCharCount
232233
)
233234
LOG.debug {
234235
"Successfully sent user trigger decision telemetry. RequestId: ${response.responseMetadata().requestId()}"

plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererTelemetryServiceNew.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,8 @@ class CodeWhispererTelemetryServiceNew {
230230
suggestionState,
231231
suggestionReferenceCount,
232232
generatedLineCount,
233-
recommendationContext.details.size
233+
recommendationContext.details.size,
234+
acceptedCharCount
234235
)
235236
LOG.debug {
236237
"Successfully sent user trigger decision telemetry. RequestId: ${response.responseMetadata().requestId()}"

plugins/amazonq/codewhisperer/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/codewhisperer/CodeWhispererClientAdaptorTest.kt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,8 @@ class CodeWhispererClientAdaptorTest {
262262
CodewhispererSuggestionState.Accept,
263263
3,
264264
1,
265-
2
265+
2,
266+
10
266267
)
267268

268269
argumentCaptor<SendTelemetryEventRequest>().apply {
@@ -275,6 +276,7 @@ class CodeWhispererClientAdaptorTest {
275276
assertThat(it.generatedLine()).isEqualTo(1)
276277
assertThat(it.recommendationLatencyMilliseconds()).isEqualTo(20.0)
277278
assertThat(it.numberOfRecommendations()).isEqualTo(2)
279+
assertThat(it.acceptedCharacterCount()).isEqualTo(10)
278280
}
279281
}
280282
}
@@ -380,7 +382,8 @@ class CodeWhispererClientAdaptorTest {
380382
aSuggestionState(),
381383
0,
382384
1,
383-
2
385+
2,
386+
10
384387
)
385388
}
386389
}

plugins/amazonq/codewhisperer/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/codewhisperer/CodeWhispererTelemetryServiceTest.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ class CodeWhispererTelemetryServiceTest {
8686
mockClient = spy(CodeWhispererClientAdaptor.getInstance(projectRule.project))
8787
mockClient.stub {
8888
onGeneric {
89-
sendUserTriggerDecisionTelemetry(any(), any(), any(), any(), any(), any(), any())
89+
sendUserTriggerDecisionTelemetry(any(), any(), any(), any(), any(), any(), any(), any())
9090
}.doAnswer {
9191
mock<SendTelemetryEventResponse>()
9292
}
@@ -468,6 +468,7 @@ class CodeWhispererTelemetryServiceTest {
468468
eq(expectedSuggestionReferenceCount),
469469
eq(expectedGeneratedLineCount),
470470
eq(expectedRecommendationContext.details.size),
471+
eq(expectedCharCount)
471472
)
472473
} else {
473474
verifyNoInteractions(mockClient)

0 commit comments

Comments
 (0)