Skip to content

Commit adb4f48

Browse files
committed
fix(amazonqFeatureDev): include defaults for empty string
1 parent 6e8bb5a commit adb4f48

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/clients/FeatureDevClient.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ class FeatureDevClient(private val project: Project) {
107107
)
108108
}
109109

110-
fun startTaskAssistCodeGeneration(conversationId: String, uploadId: String, userMessage: String, codeGenerationId: UUID, currentCodeGenerationId: UUID?): StartTaskAssistCodeGenerationResponse = bearerClient()
110+
fun startTaskAssistCodeGeneration(conversationId: String, uploadId: String, userMessage: String, codeGenerationId: UUID, currentCodeGenerationId: String?): StartTaskAssistCodeGenerationResponse = bearerClient()
111111
.startTaskAssistCodeGeneration {
112112
request ->
113113
request
@@ -121,7 +121,7 @@ class FeatureDevClient(private val project: Project) {
121121
it
122122
.programmingLanguage { pl -> pl.languageName("javascript") } // This parameter is omitted by featureDev but required in the request
123123
.uploadId(uploadId)
124-
}.codeGenerationId(codeGenerationId.toString()).currentCodeGenerationId(currentCodeGenerationId.toString())
124+
}.codeGenerationId(codeGenerationId.toString()).currentCodeGenerationId(currentCodeGenerationId)
125125
}
126126

127127
fun getTaskAssistCodeGeneration(conversationId: String, codeGenerationId: String): GetTaskAssistCodeGenerationResponse = bearerClient()

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/CodeGenerationState.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ class CodeGenerationState(
4646
var numberOfFilesGenerated: Int? = null
4747
try {
4848
val codeGenerationId = UUID.randomUUID()
49+
50+
4951
val response = config.featureDevService.startTaskAssistCodeGeneration(
5052
conversationId = config.conversationId,
5153
uploadId = uploadId,
@@ -54,6 +56,10 @@ class CodeGenerationState(
5456
currentCodeGenerationId = currentCodeGenerationId
5557
)
5658

59+
if (action.token?.token()?.isCancellationRequested != true) {
60+
this.currentCodeGenerationId = codeGenerationId
61+
}
62+
5763
messenger.sendAnswerPart(
5864
tabId = tabID,
5965
message = message("amazonqFeatureDev.code_generation.generating_code")

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/util/FeatureDevService.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ class FeatureDevService(val proxyClient: FeatureDevClient, val project: Project)
116116
uploadId,
117117
message,
118118
codeGenerationId,
119-
currentCodeGenerationId
119+
currentCodeGenerationId?.toString() ?: "EMPTY_CURRENT_CODE_GENERATION_ID"
120120
)
121121

122122
logger.debug { "$FEATURE_NAME: Started code generation with requestId: ${startCodeGenerationResponse.responseMetadata().requestId()}" }

plugins/amazonq/mynah-ui/src/mynah-ui/ui/main.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ export const createMynahUI = (ideApi: any, featureDevInitEnabled: boolean, codeT
127127
mynahUI.updateStore(tabID, {
128128
loadingChat: true,
129129
promptInputDisabledState: true,
130+
cancelButtonWhenLoading: true,
130131
})
131132
if (message) {
132133
mynahUI.updateLastChatAnswer(tabID, {
@@ -266,6 +267,7 @@ export const createMynahUI = (ideApi: any, featureDevInitEnabled: boolean, codeT
266267
) {
267268
mynahUI.updateStore(tabID, {
268269
loadingChat: true,
270+
cancelButtonWhenLoading: false,
269271
promptInputDisabledState: true,
270272
})
271273

0 commit comments

Comments
 (0)