Fix plugin initialization exception due to service loader issues (#2967)

Author: rli

jetbrains-core/src/software/aws/toolkits/jetbrains/core/execution/AwsConnectionExtension.kt

@@ -23,10 +23,9 @@ import software.aws.toolkits.telemetry.Result.Failed
 import software.aws.toolkits.telemetry.Result.Succeeded
 
 class AwsConnectionRunConfigurationExtension<T : RunConfigurationBase<*>> {
-    private val regionProvider = AwsRegionProvider.getInstance()
-    private val credentialManager = CredentialManager.getInstance()
-
     fun addEnvironmentVariables(configuration: T, environment: MutableMap<String, String>, runtimeString: () -> String? = { null }) {
+        val regionProvider = AwsRegionProvider.getInstance()
+        val credentialManager = CredentialManager.getInstance()
         val credentialConfiguration = configuration.getCopyableUserData(AWS_CONNECTION_RUN_CONFIGURATION_KEY) ?: return
 
         try {

jetbrains-core/src/software/aws/toolkits/jetbrains/services/telemetry/TelemetryService.kt

@@ -126,8 +126,11 @@ abstract class TelemetryService(private val publisher: TelemetryPublisher, priva
     }
 }
 
-class DefaultTelemetryService : TelemetryService(PUBLISHER, DefaultTelemetryBatcher(PUBLISHER)) {
+class DefaultTelemetryService : TelemetryService {
+    constructor() : super(publisher, batcher)
+
     private companion object {
-        val PUBLISHER = DefaultTelemetryPublisher()
+        private val publisher: TelemetryPublisher by lazy { DefaultTelemetryPublisher() }
+        private val batcher: TelemetryBatcher by lazy { DefaultTelemetryBatcher(publisher) }
     }
 }

jetbrains-core/tst/software/aws/toolkits/jetbrains/services/telemetry/MockTelemetryService.kt

@@ -6,9 +6,17 @@ package software.aws.toolkits.jetbrains.services.telemetry
 import software.amazon.awssdk.services.toolkittelemetry.model.Sentiment
 import software.aws.toolkits.core.telemetry.DefaultTelemetryBatcher
 import software.aws.toolkits.core.telemetry.MetricEvent
+import software.aws.toolkits.core.telemetry.TelemetryBatcher
 import software.aws.toolkits.core.telemetry.TelemetryPublisher
 
-class NoOpTelemetryService() : TelemetryService(NoOpPublisher(), DefaultTelemetryBatcher(NoOpPublisher()))
+class NoOpTelemetryService : TelemetryService {
+    constructor() : super(publisher, batcher)
+
+    private companion object {
+        private val publisher: TelemetryPublisher by lazy { NoOpPublisher() }
+        private val batcher: TelemetryBatcher by lazy { DefaultTelemetryBatcher(publisher) }
+    }
+}
 
 class NoOpPublisher() : TelemetryPublisher {
     override suspend fun publish(metricEvents: Collection<MetricEvent>) {}

jetbrains-core/tst/software/aws/toolkits/jetbrains/services/telemetry/TelemetryServiceTest.kt

@@ -40,7 +40,7 @@ import java.util.concurrent.CountDownLatch
 import java.util.concurrent.TimeUnit
 
 class TelemetryServiceTest {
-    private class TestTelemetryService(publlisher: TelemetryPublisher = NoOpPublisher(), batcher: TelemetryBatcher) : TelemetryService(publlisher, batcher)
+    private class TestTelemetryService(publisher: TelemetryPublisher = NoOpPublisher(), batcher: TelemetryBatcher) : TelemetryService(publisher, batcher)
 
     @Rule
     @JvmField