Don't make run configurations in test sources (#3148)

Author: rli

.changes/next-release/bugfix-e738e852-8523-42f8-8bda-5f750a5f8cdb.json

@@ -0,0 +1,4 @@
+{
+  "type" : "bugfix",
+  "description" : "Don't attempt to setup run configurations for test code (#3075)"
+}

jetbrains-core/src/software/aws/toolkits/jetbrains/services/lambda/execution/local/LocalLambdaRunConfigurationProducer.kt

@@ -10,6 +10,7 @@ import com.intellij.execution.actions.LazyRunConfigurationProducer
 import com.intellij.execution.configurations.ConfigurationFactory
 import com.intellij.openapi.module.ModuleUtilCore
 import com.intellij.openapi.project.Project
+import com.intellij.openapi.roots.TestSourcesFilter
 import com.intellij.openapi.util.Ref
 import com.intellij.psi.PsiElement
 import org.jetbrains.yaml.psi.YAMLKeyValue
@@ -55,6 +56,11 @@ class LocalLambdaRunConfigurationProducer : LazyRunConfigurationProducer<LocalLa
         if (runtimeGroup !in LambdaHandlerResolver.supportedRuntimeGroups()) {
             return false
         }
+
+        if (context.location?.virtualFile?.let { TestSourcesFilter.isTestSources(it, element.project) } == true) {
+            return false
+        }
+
         val resolver = LambdaHandlerResolver.getInstance(runtimeGroup)
         val handler = resolver.determineHandler(element) ?: return false
 

jetbrains-core/tst/software/aws/toolkits/jetbrains/services/lambda/execution/local/LocalLambdaRunConfigurationProducerTest.kt

@@ -20,17 +20,20 @@ import org.junit.Rule
 import org.junit.Test
 import software.aws.toolkits.core.lambda.LambdaRuntime
 import software.aws.toolkits.jetbrains.services.lambda.sam.findByLocation
-import software.aws.toolkits.jetbrains.utils.rules.JavaCodeInsightTestFixtureRule
+import software.aws.toolkits.jetbrains.utils.rules.HeavyJavaCodeInsightTestFixtureRule
+import software.aws.toolkits.jetbrains.utils.rules.addModule
+import software.aws.toolkits.jetbrains.utils.rules.addTestClass
 import software.aws.toolkits.jetbrains.utils.rules.openClass
 import kotlin.test.assertNotNull
 
 class LocalLambdaRunConfigurationProducerTest {
     @Rule
     @JvmField
-    val projectRule = JavaCodeInsightTestFixtureRule()
+    val projectRule = HeavyJavaCodeInsightTestFixtureRule()
 
     @Test
     fun validRunConfigurationIsCreated() {
+        projectRule.fixture.addModule("main")
         val psiClass = projectRule.fixture.openClass(
             """
             package com.example;
@@ -55,6 +58,29 @@ class LocalLambdaRunConfigurationProducerTest {
         }
     }
 
+    @Test
+    fun `does not create run configuration for test class`() {
+        val newModule = projectRule.fixture.addModule("newModule")
+        val psiClass = projectRule.fixture.addTestClass(
+            newModule,
+            """
+            package com.example;
+
+            public class LambdaHandler {
+                public String handleRequest(String request) {
+                    return request.toUpperCase();
+                }
+            }
+            """
+        )
+
+        val lambdaMethod = psiClass.findMethodsByName("handleRequest", false).first()
+        runInEdtAndWait {
+            val runConfiguration = createRunConfiguration(lambdaMethod)
+            assertThat(runConfiguration).isNull()
+        }
+    }
+
     @Test
     fun validRunConfigurationIsCreatedFromTemplate() {
         runInEdtAndWait {
@@ -110,6 +136,7 @@ Resources:
 
     @Test
     fun invalidLambdaIsNotCreated() {
+        projectRule.fixture.addModule("main")
         val psiClass = projectRule.fixture.openClass(
             """
             package com.example;