Skip to content

Commit b2a60fd

Browse files
committed
fix detekt
1 parent 05b2ced commit b2a60fd

File tree

3 files changed

+11
-27
lines changed

3 files changed

+11
-27
lines changed

plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/editor/CodeWhispererEditorManagerNew.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ class CodeWhispererEditorManagerNew {
5353
preview.detail.isAccepted = true
5454

5555
WriteCommandAction.runWriteCommandAction(project) {
56-
5756
ApplicationManager.getApplication().messageBus.syncPublisher(Q_FEATURE_TOPIC)
5857
.onEvent(QFeatureEvent.STARTS_EDITING)
5958
document.replaceString(originalOffset, endOffsetToReplace, reformatted)

plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/telemetry/UserWrittenCodeTracker.kt

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import java.time.Duration
2727
import java.util.concurrent.atomic.AtomicBoolean
2828
import java.util.concurrent.atomic.AtomicInteger
2929

30-
3130
@Service(Service.Level.PROJECT)
3231
class UserWrittenCodeTracker(private val project: Project) : Disposable {
3332
val userWrittenCodeLineCount = mutableMapOf<CodeWhispererProgrammingLanguage, Long>()
@@ -50,7 +49,7 @@ class UserWrittenCodeTracker(private val project: Project) : Disposable {
5049
Q_FEATURE_TOPIC,
5150
object : QFeatureListener {
5251
override fun onEvent(event: QFeatureEvent) {
53-
when(event) {
52+
when (event) {
5453
QFeatureEvent.INVOCATION -> qInvocationCount.getAndIncrement()
5554
QFeatureEvent.STARTS_EDITING -> isQMakingEdits.set(true)
5655
QFeatureEvent.FINISHES_EDITING -> isQMakingEdits.set(false)
@@ -121,15 +120,12 @@ class UserWrittenCodeTracker(private val project: Project) : Disposable {
121120
}
122121

123122
// intelliJ sometimes insert multi spaces for indentation, this is not user written code
124-
private fun isIntelliJMultiSpacesInsert(text: String): Boolean {
125-
return text.trim { it == ' ' }.isEmpty() && text.length > 1
126-
}
127-
123+
private fun isIntelliJMultiSpacesInsert(text: String) = text.trim { it == ' ' }.isEmpty() && text.length > 1
128124

129125
private fun emitCodeWhispererCodeContribution() {
130126
val customizationArn: String? = CodeWhispererModelConfigurator.getInstance().activeCustomization(project)?.arn
131127
for ((language, _) in userWrittenCodeCharacterCount) {
132-
if (userWrittenCodeCharacterCount.getOrDefault(language, 0) <= 0 ) {
128+
if (userWrittenCodeCharacterCount.getOrDefault(language, 0) <= 0) {
133129
continue
134130
}
135131
runIfIdcConnectionOrTelemetryEnabled(project) {
@@ -153,7 +149,6 @@ class UserWrittenCodeTracker(private val project: Project) : Disposable {
153149
}
154150
}
155151
}
156-
157152
}
158153

159154
companion object {
@@ -168,7 +163,6 @@ class UserWrittenCodeTracker(private val project: Project) : Disposable {
168163
"Q service events",
169164
QFeatureListener::class.java
170165
)
171-
172166
}
173167

174168
override fun dispose() {
@@ -187,10 +181,9 @@ class UserWrittenCodeTracker(private val project: Project) : Disposable {
187181
enum class QFeatureEvent {
188182
INVOCATION,
189183
STARTS_EDITING,
190-
FINISHES_EDITING
184+
FINISHES_EDITING,
191185
}
192186

193187
interface QFeatureListener {
194188
fun onEvent(event: QFeatureEvent)
195189
}
196-

plugins/amazonq/codewhisperer/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/codewhisperer/UserWrittenCodeTrackerTest.kt

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ package software.aws.toolkits.jetbrains.services.codewhisperer
66
import com.intellij.openapi.application.ApplicationManager
77
import com.intellij.openapi.command.WriteCommandAction
88
import com.intellij.openapi.editor.Editor
9-
import com.intellij.openapi.editor.event.DocumentEvent
109
import com.intellij.openapi.project.Project
1110
import com.intellij.testFramework.DisposableRule
1211
import com.intellij.testFramework.fixtures.CodeInsightTestFixture
@@ -17,13 +16,10 @@ import org.junit.After
1716
import org.junit.Before
1817
import org.junit.Rule
1918
import org.junit.Test
20-
import org.mockito.internal.verification.Times
2119
import org.mockito.kotlin.any
22-
import org.mockito.kotlin.argumentCaptor
2320
import org.mockito.kotlin.doReturn
2421
import org.mockito.kotlin.mock
2522
import org.mockito.kotlin.spy
26-
import org.mockito.kotlin.verify
2723
import software.aws.toolkits.core.telemetry.TelemetryBatcher
2824
import software.aws.toolkits.core.telemetry.TelemetryPublisher
2925
import software.aws.toolkits.jetbrains.core.MockClientManagerRule
@@ -44,7 +40,7 @@ import software.aws.toolkits.jetbrains.utils.rules.PythonCodeInsightTestFixtureR
4440

4541
internal class UserWrittenCodeTrackerTest {
4642

47-
protected class TestTelemetryService(
43+
internal class TestTelemetryService(
4844
publisher: TelemetryPublisher = NoOpPublisher(),
4945
batcher: TelemetryBatcher,
5046
) : TelemetryService(publisher, batcher)
@@ -61,12 +57,12 @@ internal class UserWrittenCodeTrackerTest {
6157
@JvmField
6258
val mockClientManagerRule = MockClientManagerRule()
6359

64-
protected lateinit var project: Project
65-
protected lateinit var fixture: CodeInsightTestFixture
66-
protected lateinit var telemetryServiceSpy: TelemetryService
67-
protected lateinit var batcher: TelemetryBatcher
68-
protected lateinit var exploreActionManagerMock: CodeWhispererExplorerActionManager
69-
protected lateinit var sut: UserWrittenCodeTracker
60+
lateinit var project: Project
61+
lateinit var fixture: CodeInsightTestFixture
62+
lateinit var telemetryServiceSpy: TelemetryService
63+
lateinit var batcher: TelemetryBatcher
64+
lateinit var exploreActionManagerMock: CodeWhispererExplorerActionManager
65+
lateinit var sut: UserWrittenCodeTracker
7066

7167
init {
7268
this.projectRule = PythonCodeInsightTestFixtureRule()
@@ -113,7 +109,6 @@ internal class UserWrittenCodeTrackerTest {
113109
assertThat(sut.qInvocationCount.get()).isEqualTo(2)
114110
}
115111

116-
117112
@Test
118113
fun `test tracker is not listening to multi char input more than 50, but works for less than 50, and will not increment totalTokens - add new code`() {
119114
sut = UserWrittenCodeTracker.getInstance(project)
@@ -153,7 +148,6 @@ internal class UserWrittenCodeTrackerTest {
153148
assertThat(sut.userWrittenCodeCharacterCount.getOrDefault(CodeWhispererPython.INSTANCE, 0)).isEqualTo(0)
154149
}
155150

156-
157151
@Test
158152
fun `test tracker is listening to document changes only when Q is not editing`() {
159153
sut = UserWrittenCodeTracker.getInstance(project)
@@ -180,13 +174,11 @@ internal class UserWrittenCodeTrackerTest {
180174
}
181175
assertThat(sut.userWrittenCodeCharacterCount[CodeWhispererPython.INSTANCE]).isEqualTo(newCode.length.toLong())
182176
assertThat(sut.userWrittenCodeLineCount[CodeWhispererPython.INSTANCE]).isEqualTo(1)
183-
184177
}
185178

186179
private fun Editor.appendString(string: String) {
187180
val currentOffset = caretModel.primaryCaret.offset
188181
document.insertString(currentOffset, string)
189182
caretModel.moveToOffset(currentOffset + string.length)
190183
}
191-
192184
}

0 commit comments

Comments
 (0)