fix(amazonq): show users a notification when download fails (#4824)

* fix(amazonq): show notification on download failure

* delete file

* add error message

* add changelog entry

* update error message

---------

Co-authored-by: David Hasani <[email protected]>

Author: dhasani23

.changes/next-release/bugfix-a9de376d-3ae7-4c30-96bd-4a8529534d87.json

@@ -0,0 +1,4 @@
+{
+  "type" : "bugfix",
+  "description" : "Amazon Q Code Transformation: show an error notification when download diff fails"
+}

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/ArtifactHandler.kt

@@ -27,8 +27,10 @@ import software.aws.toolkits.jetbrains.core.coroutines.getCoroutineBgContext
 import software.aws.toolkits.jetbrains.core.coroutines.projectCoroutineScope
 import software.aws.toolkits.jetbrains.core.credentials.sso.bearer.NoTokenInitializedException
 import software.aws.toolkits.jetbrains.services.amazonq.CODE_TRANSFORM_TROUBLESHOOT_DOC_DOWNLOAD_ERROR_OVERVIEW
+import software.aws.toolkits.jetbrains.services.amazonq.CODE_TRANSFORM_TROUBLESHOOT_DOC_DOWNLOAD_EXPIRED
 import software.aws.toolkits.jetbrains.services.codemodernizer.client.GumbyClient
 import software.aws.toolkits.jetbrains.services.codemodernizer.commands.CodeTransformMessageListener
+import software.aws.toolkits.jetbrains.services.codemodernizer.constants.getDownloadedArtifactTextFromType
 import software.aws.toolkits.jetbrains.services.codemodernizer.model.CodeModernizerArtifact
 import software.aws.toolkits.jetbrains.services.codemodernizer.model.CodeTransformFailureBuildLog
 import software.aws.toolkits.jetbrains.services.codemodernizer.model.CodeTransformHilDownloadArtifact
@@ -275,10 +277,12 @@ class ArtifactHandler(private val project: Project, private val clientAdaptor: G
     }
 
     fun notifyUnableToDownload(error: DownloadFailureReason) {
-        // Inform chat about failure
+        // Inform about failure
         LOG.error { "Unable to download artifact: $error" }
         CodeTransformMessageListener.instance.onDownloadFailure(error)
 
+        val artifactText = getDownloadedArtifactTextFromType(error.artifactType)
+
         // Display notification balloon if applicable
         when (error) {
             is DownloadFailureReason.PROXY_WILDCARD_ERROR -> notifyStickyWarn(
@@ -310,8 +314,25 @@ class ArtifactHandler(private val project: Project, private val clientAdaptor: G
                 )
             }
 
-            is DownloadFailureReason.OTHER, is DownloadFailureReason.INVALID_ARTIFACT -> {
-                // No notification, only chat update
+            is DownloadFailureReason.INVALID_ARTIFACT -> {
+                if (error.artifactType == TransformationDownloadArtifactType.CLIENT_INSTRUCTIONS) {
+                    notifyStickyWarn(
+                        message("codemodernizer.notification.warn.download_failed_client_instructions_expired"),
+                        CODE_TRANSFORM_TROUBLESHOOT_DOC_DOWNLOAD_EXPIRED,
+                    )
+                } else {
+                    notifyStickyWarn(
+                        message("codemodernizer.notification.warn.download_failed_invalid_artifact", artifactText),
+                        CODE_TRANSFORM_TROUBLESHOOT_DOC_DOWNLOAD_EXPIRED,
+                    )
+                }
+            }
+
+            is DownloadFailureReason.OTHER -> {
+                notifyStickyWarn(
+                    message("codemodernizer.notification.warn.download_failed_other.content", artifactText, error.errorMessage),
+                    CODE_TRANSFORM_TROUBLESHOOT_DOC_DOWNLOAD_ERROR_OVERVIEW,
+                )
             }
         }
     }

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/constants/CodeTransformChatItems.kt

@@ -536,7 +536,7 @@ fun buildDownloadFailureChatContent(downloadFailureReason: DownloadFailureReason
     )
 }
 
-private fun getDownloadedArtifactTextFromType(artifactType: TransformationDownloadArtifactType): String =
+fun getDownloadedArtifactTextFromType(artifactType: TransformationDownloadArtifactType): String =
     when (artifactType) {
         TransformationDownloadArtifactType.CLIENT_INSTRUCTIONS -> "upgraded code"
         TransformationDownloadArtifactType.LOGS -> "build log"

plugins/core/resources/resources/software/aws/toolkits/resources/MessagesBundle.properties

@@ -606,7 +606,6 @@ codemodernizer.chat.message.hil.user_rejected=I'll continue upgrading your modul
 codemodernizer.chat.message.local_build_begin=I'm building your module. This can take up to 10 minutes, depending on the size of your module.
 codemodernizer.chat.message.local_build_failed=Sorry, I couldn't run the Maven clean install command to build your module.
 codemodernizer.chat.message.local_build_success=I was able to build your project and will start uploading your code.
-codemodernizer.chat.message.reauth_success=Please start a new transformation job and try submitting the job again.
 codemodernizer.chat.message.result.fail=Sorry, I ran into an issue during the transformation. Please try again.
 codemodernizer.chat.message.result.fail_initial_build=I am having trouble building your project in the secure build environment and couldn't complete the transformation.
 codemodernizer.chat.message.result.fail_initial_build_no_build_log=I am having trouble building your project in the secure build environment: {0}.
@@ -646,9 +645,6 @@ codemodernizer.explorer.show_transformation_plan_title=View your code transforma
 codemodernizer.explorer.show_transformation_summary_title=View your code transformation summary
 codemodernizer.explorer.stop_migration_job=Stop Transformation
 codemodernizer.file.invalid_pom_version=Amazon Q experienced an issue upgrading this dependency version. Use Amazon Q chat to upgrade the version of this dependency to a Java 17 compatible version.
-codemodernizer.manager.job_failed_content=The transformation job failed when you were away with reason: {0}
-codemodernizer.manager.job_finished_content=The transformation job completed while you were away
-codemodernizer.manager.job_finished_title=Job Finished
 codemodernizer.manager.job_ongoing_content=Amazon Q is still transforming your code. To see the current status of the transformation, go to the Transformation Hub.
 codemodernizer.manager.job_ongoing_title=Code Transformation ongoing
 codemodernizer.migration_plan.body.info.action_column=Action
@@ -699,7 +695,10 @@ codemodernizer.notification.info.transformation_stop.content=You cancelled the t
 codemodernizer.notification.info.transformation_stop.title=Transformation cancelled
 codemodernizer.notification.info.view_troubleshooting_guide=View troubleshooting guide
 codemodernizer.notification.warn.action.reauthenticate=Reauthenticate
+codemodernizer.notification.warn.download_failed_client_instructions_expired=Your transformation is not available anymore. Your code and transformation summary are deleted 24 hours after the transformation completes. Please try starting the transformation again.
 codemodernizer.notification.warn.download_failed_expired_credentials.content=Unable to download results as your credentials expired, please reauthenticate to Q and try again.
+codemodernizer.notification.warn.download_failed_invalid_artifact=Amazon Q was unable to find your {0}. Artifacts are deleted after 24 hours. Please try starting the transformation again.
+codemodernizer.notification.warn.download_failed_other.content=Amazon Q ran into an issue while trying to download your {0}. Please try again. {1}
 codemodernizer.notification.warn.download_failed_ssl.content=Please make sure all your certificates for your proxy client have been set up correctly for your IDE.
 codemodernizer.notification.warn.download_failed_wildcard.content=Check your IDE proxy settings and remove any wildcard (*) references, and then try viewing the diff again.
 codemodernizer.notification.warn.expired_credentials.title=Your connection to Q has expired