Merge branch 'main' into fix/cancel-button

Author: aggagen

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/CodeModernizerSession.kt

@@ -61,6 +61,7 @@ import java.net.ConnectException
 import java.net.SocketTimeoutException
 import java.net.UnknownHostException
 import java.nio.file.Path
+import java.time.Duration
 import java.time.Instant
 import java.util.Base64
 import java.util.concurrent.CancellationException
@@ -408,8 +409,10 @@ class CodeModernizerSession(
                 UnknownHostException::class,
                 SocketTimeoutException::class,
                 HttpRequests.HttpStatusException::class,
-                ConnectException::class
-            )
+                ConnectException::class,
+                IOException::class,
+            ),
+            maxDuration = Duration.ofMinutes(5)
         ) {
             clientAdaptor.uploadArtifactToS3(
                 createUploadUrlResponse.uploadUrl(),

plugins/amazonq/codetransform/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/codemodernizer/CodeWhispererCodeModernizerSessionTest.kt

@@ -67,7 +67,6 @@ import software.aws.toolkits.jetbrains.utils.rules.HeavyJavaCodeInsightTestFixtu
 import software.aws.toolkits.jetbrains.utils.rules.addFileToModule
 import java.io.File
 import java.io.FileInputStream
-import java.io.IOException
 import java.net.ConnectException
 import java.util.Base64
 import java.util.zip.ZipFile
@@ -478,13 +477,13 @@ class CodeWhispererCodeModernizerSessionTest : CodeWhispererCodeModernizerTestBa
     }
 
     @Test
-    fun `CodeModernizer cannot upload payload due to unknown issue`() = runTest {
+    fun `CodeModernizer cannot upload payload due to unknown client-side issue`() = runTest {
         doReturn(ZipCreationResult.Succeeded(File("./tst-resources/codemodernizer/test.txt")))
             .whenever(testSessionContextSpy).createZipWithModuleFiles(any())
         doReturn(exampleCreateUploadUrlResponse).whenever(clientAdaptorSpy).createGumbyUploadUrl(any())
-        doAnswer { throw IOException("mock exception") }.whenever(clientAdaptorSpy).uploadArtifactToS3(any(), any(), any(), any(), any())
+        doAnswer { throw Exception("mock client-side exception") }.whenever(clientAdaptorSpy).uploadArtifactToS3(any(), any(), any(), any(), any())
         val result = testSessionSpy.createModernizationJob(MavenCopyCommandsResult.Success(File("./mock/path/")))
-        assertEquals(CodeModernizerStartJobResult.ZipUploadFailed(UploadFailureReason.OTHER("mock exception")), result)
+        assertEquals(CodeModernizerStartJobResult.ZipUploadFailed(UploadFailureReason.OTHER("mock client-side exception")), result)
         verify(testSessionStateSpy, times(1)).putJobHistory(any(), eq(TransformationStatus.FAILED), any(), any())
         assertEquals(testSessionStateSpy.currentJobStatus, TransformationStatus.FAILED)
     }

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/services/telemetry/PluginResolver.kt

@@ -45,7 +45,7 @@ class PluginResolver private constructor(callerStackTrace: Array<StackTraceEleme
          * Sets a PluginResolver instance to a thread-local for the current thread.
          * This value will be retrieved by subsequent calls to fromCurrentThread.
          */
-        fun setThreadLocal(value: PluginResolver) {
+        fun setThreadLocal(value: PluginResolver?) {
             threadLocalResolver.set(value)
         }
     }

plugins/core/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/telemetry/PluginResolverTest.kt

@@ -6,28 +6,25 @@ package software.aws.toolkits.jetbrains.services.telemetry
 import com.intellij.ide.plugins.IdeaPluginDescriptor
 import com.intellij.ide.plugins.PluginManagerCore
 import io.mockk.called
-import io.mockk.clearAllMocks
 import io.mockk.every
+import io.mockk.junit5.MockKExtension
 import io.mockk.mockk
 import io.mockk.mockkStatic
 import io.mockk.verify
 import junit.framework.TestCase.assertEquals
-import org.junit.jupiter.api.AfterEach
 import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.Test
+import org.junit.jupiter.api.extension.ExtendWith
 import software.amazon.awssdk.services.toolkittelemetry.model.AWSProduct
 
+@ExtendWith(MockKExtension::class)
 class PluginResolverTest {
     @BeforeEach
     fun setup() {
+        PluginResolver.setThreadLocal(null)
         mockkStatic(PluginManagerCore::class)
     }
 
-    @AfterEach
-    fun tearDown() {
-        clearAllMocks()
-    }
-
     @Test
     fun getsProductForAmazonQPlugin() {
         val pluginDescriptor = mockk<IdeaPluginDescriptor> {

plugins/core/jetbrains-community/tst/software/aws/toolkits/jetbrains/utils/ThreadingUtilsKtTest.kt

@@ -10,7 +10,8 @@ import com.intellij.openapi.progress.ProgressManager
 import com.intellij.testFramework.ApplicationRule
 import com.intellij.util.concurrency.AppExecutorUtil
 import io.mockk.every
-import io.mockk.mockk
+import io.mockk.impl.annotations.MockK
+import io.mockk.junit4.MockKRule
 import org.assertj.core.api.Assertions.assertThatThrownBy
 import org.junit.Assert.assertEquals
 import org.junit.Rule
@@ -26,6 +27,12 @@ class ThreadingUtilsKtTest {
     @JvmField
     val application = ApplicationRule()
 
+    @get:Rule
+    val mockkRule = MockKRule(this)
+
+    @MockK
+    private lateinit var pluginResolver: PluginResolver
+
     @Test
     fun `computeOnEdt runs on edt`() {
         computeOnEdt {
@@ -78,13 +85,13 @@ class ThreadingUtilsKtTest {
 
     @Test
     fun `pluginAwareExecuteOnPooledThread inherits plugin resolver`() {
-        val pluginResolver = mockk<PluginResolver> {
-            every { product } returns AWSProduct.AMAZON_Q_FOR_JET_BRAINS
-        }
+        every { pluginResolver.product } returns AWSProduct.AMAZON_Q_FOR_JET_BRAINS
         PluginResolver.setThreadLocal(pluginResolver)
 
         pluginAwareExecuteOnPooledThread {
             assertEquals(PluginResolver.fromCurrentThread().product, AWSProduct.AMAZON_Q_FOR_JET_BRAINS)
         }.get()
+
+        PluginResolver.setThreadLocal(PluginResolver.fromStackTrace(Thread.currentThread().stackTrace))
     }
 }