fix detekt issues

Author: samgst-amazon

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/notifications/NotificationPollingService.kt

@@ -31,14 +31,13 @@ private const val MAX_RETRIES = 3
 private const val RETRY_DELAY_MS = 1000L
 
 object NotificationFileValidator : RemoteResolveParser {
-    override fun canBeParsed(data: InputStream): Boolean {
-        return try {
+    override fun canBeParsed(data: InputStream): Boolean =
+        try {
             NotificationMapperUtil.mapper.readValue<NotificationsList>(data)
             true
         } catch (e: Exception) {
             false
         }
-    }
 }
 
 @State(name = "NotificationETagState", storages = [Storage("aws.xml", roamingType = RoamingType.DISABLED)])
@@ -96,7 +95,7 @@ class NotificationPollingService : Disposable {
                     }
                     return false
                 }
-                val resolvedPath = resourceResolver.get()
+                resourceResolver.get()
                     .resolve(notificationsResource)
                     .toCompletableFuture()
                     .get()

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt

@@ -19,11 +19,11 @@ class ProcessNotificationsBase {
 
     init {
         NotificationPollingService.getInstance().addObserver {
-            val list = getNotificationsFromFile()
+            getNotificationsFromFile()
         }
     }
 
-    fun getNotificationsFromFile(): NotificationsList? {
+    private fun getNotificationsFromFile(): NotificationsList? {
         val path = Paths.get(PathManager.getSystemPath(), NOTIFICATIONS_PATH)
         val content = path.inputStream().bufferedReader().use { it.readText() }
         if (content.isEmpty()) {