codewhisperer: remove build requirement (#4025)

* fix(codewhisperer): remove build requirement for java

* add test case

Author: ctlai95

.changes/next-release/bugfix-0451fd5a-678f-4947-b678-50fc9ce28eb5.json

@@ -0,0 +1,4 @@
+{
+  "type" : "bugfix",
+  "description" : "CodeWhisperer: Security scans for Java no longer require build artifacts"
+}

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/codescan/sessionconfig/JavaCodeScanSessionConfig.kt

@@ -16,7 +16,6 @@ import software.aws.toolkits.core.utils.debug
 import software.aws.toolkits.core.utils.error
 import software.aws.toolkits.core.utils.exists
 import software.aws.toolkits.core.utils.getLogger
-import software.aws.toolkits.jetbrains.services.codewhisperer.codescan.cannotFindBuildArtifacts
 import software.aws.toolkits.jetbrains.services.codewhisperer.codescan.fileTooLarge
 import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants.JAVA_CODE_SCAN_TIMEOUT_IN_SECONDS
 import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants.JAVA_PAYLOAD_LIMIT_IN_BYTES
@@ -56,21 +55,18 @@ internal class JavaCodeScanSessionConfig(
         // Include all the dependencies using BFS
         val (sourceFiles, srcPayloadSize, totalLines, buildPaths) = includeDependencies()
 
-        var noClassFilesFound = true
         val outputPaths = CompilerPaths.getOutputPaths(ModuleManager.getInstance(project).modules)
         var totalBuildPayloadSize = 0L
         val buildFiles = buildPaths.mapNotNull { relativePath ->
             val classFile = findClassFile(relativePath, outputPaths)
             if (classFile == null) {
                 LOG.debug { "Cannot find class file for $relativePath" }
             } else {
-                noClassFilesFound = false
                 totalBuildPayloadSize += classFile.toFile().length()
             }
             classFile
         }
         LOG.debug { "Total build files sent in payload: ${buildFiles.size}" }
-        if (noClassFilesFound) cannotFindBuildArtifacts()
 
         // Copy all the included source and build files to the source zip
         val srcZip = zipFiles(sourceFiles.mapNotNull { getPath(it) } + buildFiles)

jetbrains-core/tst/software/aws/toolkits/jetbrains/services/codewhisperer/codescan/CodeWhispererJavaCodeScanTest.kt

@@ -21,13 +21,15 @@ import kotlinx.coroutines.runBlocking
 import org.assertj.core.api.Assertions.assertThat
 import org.junit.Before
 import org.junit.Test
+import org.junit.jupiter.api.assertDoesNotThrow
 import org.junit.jupiter.api.assertThrows
 import org.mockito.kotlin.any
 import org.mockito.kotlin.spy
 import org.mockito.kotlin.stub
 import software.aws.toolkits.jetbrains.core.compileProjectAndWait
 import software.aws.toolkits.jetbrains.services.codewhisperer.codescan.sessionconfig.CodeScanSessionConfig
 import software.aws.toolkits.jetbrains.services.codewhisperer.codescan.sessionconfig.JavaCodeScanSessionConfig
+import software.aws.toolkits.jetbrains.services.codewhisperer.codescan.sessionconfig.PayloadMetadata
 import software.aws.toolkits.jetbrains.utils.rules.HeavyJavaCodeInsightTestFixtureRule
 import software.aws.toolkits.jetbrains.utils.rules.addClass
 import software.aws.toolkits.jetbrains.utils.rules.addModule
@@ -153,6 +155,17 @@ class CodeWhispererJavaCodeScanTest : CodeWhispererCodeScanTestBase(HeavyJavaCod
         assertThat(filesInZip).isEqualTo(4)
     }
 
+    @Test
+    fun `create payload with no build files does not throw exception`() {
+        sessionConfigSpy.stub {
+            onGeneric { includeDependencies() }.thenReturn(PayloadMetadata(emptySet(), 0, 0, emptySet()))
+        }
+        assertDoesNotThrow {
+            val payload = sessionConfigSpy.createPayload()
+            assertThat(payload.context.buildPayloadSize).isEqualTo(0)
+        }
+    }
+
     @Test
     fun `e2e happy path integration test`() {
         assertE2ERunsSuccessfully(sessionConfigSpy, project, totalLines, 3, totalSize, 2)