Skip to content

Commit d4b3a09

Browse files
author
David Hasani
committed
add telemetry
1 parent 4f8f898 commit d4b3a09

File tree

5 files changed

+13
-4
lines changed

5 files changed

+13
-4
lines changed

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ mockitoKotlin = "5.4.0"
2525
mockk = "1.13.10"
2626
nimbus-jose-jwt = "9.40"
2727
node-gradle = "7.0.2"
28-
telemetryGenerator = "1.0.272"
28+
telemetryGenerator = "1.0.274"
2929
testLogger = "4.0.0"
3030
testRetry = "1.5.10"
3131
# test-only; platform provides slf4j transitively at runtime

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/CodeTransformTelemetryManager.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,13 @@ class CodeTransformTelemetryManager(private val project: Project) {
6767

6868
fun submitSelection(userChoice: String, customerSelection: CustomerSelection? = null, telemetryErrorMessage: String? = null) {
6969
CodetransformTelemetry.submitSelection(
70+
// TODO: remove below 2 lines (JavaSource / JavaTarget) once BI is updated to use source / target
7071
codeTransformJavaSourceVersionsAllowed = CodeTransformJavaSourceVersionsAllowed.from(customerSelection?.sourceJavaVersion?.name.orEmpty()),
7172
codeTransformJavaTargetVersionsAllowed = CodeTransformJavaTargetVersionsAllowed.from(customerSelection?.targetJavaVersion?.name.orEmpty()),
7273
codeTransformSessionId = sessionId,
7374
codeTransformProjectId = customerSelection?.let { getProjectHash(it) },
75+
source = if (userChoice == "Confirm-Java") customerSelection?.sourceJavaVersion?.name.orEmpty() else customerSelection?.sourceVendor.orEmpty(),
76+
target = if (userChoice == "Confirm-Java") customerSelection?.targetJavaVersion?.name.orEmpty() else customerSelection?.targetVendor.orEmpty(),
7477
userChoice = userChoice,
7578
result = if (telemetryErrorMessage.isNullOrEmpty()) Result.Succeeded else Result.Failed,
7679
reason = telemetryErrorMessage,

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/constants/CodeTransformChatItems.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ private val confirmUserSelectionSQLConversionModuleSchemaButton = Button(
5858
)
5959

6060
private val confirmUserSelectionSQLConversionMetadataButton = Button(
61-
keepCardAfterClick = true, // TODO: make this false if you can't figure out how to disable the Select button after its been clicked once
61+
keepCardAfterClick = true,
6262
waitMandatoryFormItems = true,
6363
text = message("codemodernizer.chat.message.button.select"),
6464
id = CodeTransformButtonId.SelectSQLMetadata.id,

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/controller/CodeTransformChatController.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ class CodeTransformChatController(
286286
codeModernizerManager.createCodeModernizerSession(selection, context.project)
287287

288288
// Publish metric to capture user selection before local build starts
289-
telemetry.submitSelection("Confirm", selection)
289+
telemetry.submitSelection("Confirm-Java", selection)
290290

291291
codeTransformChatHelper.run {
292292
addNewMessage(buildUserInputSkipTestsFlagChatIntroContent())
@@ -349,6 +349,7 @@ class CodeTransformChatController(
349349
sqlMetadataZip = extractedZip,
350350
)
351351
codeModernizerManager.createCodeModernizerSession(selection, context.project)
352+
telemetry.submitSelection("Confirm-SQL", selection)
352353
}
353354
}
354355
}

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/panels/managers/BuildProgressSplitterPanelManager.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,11 @@ class BuildProgressSplitterPanelManager(private val project: Project) :
125125

126126
fun maybeAdd(stepId: ProgressStepId, string: String) {
127127
// don't show building or generate plan message for SQL conversions since we don't build or generate plan
128-
if (transformType == CodeTransformType.SQL_CONVERSION && (string == message("codemodernizer.toolwindow.progress.building") || string == message("codemodernizer.toolwindow.progress.planning"))) {
128+
if (transformType == CodeTransformType.SQL_CONVERSION && (
129+
string == message("codemodernizer.toolwindow.progress.building") ||
130+
string == message("codemodernizer.toolwindow.progress.planning")
131+
)
132+
) {
129133
return
130134
}
131135
if (currentState.none { it.id == stepId }) {
@@ -362,6 +366,7 @@ class BuildProgressSplitterPanelManager(private val project: Project) :
362366
.toKotlinDuration().inWholeSeconds.seconds.toString() to formatter.format(Date.from(endTime))
363367
}
364368

369+
// will be False for SQL conversions, which is what we want so that the (nonexistent) progressUpdates do not render
365370
private fun haveProgressUpdates(plan: TransformationPlan): Boolean = plan.transformationSteps().any { it.progressUpdates().size > 0 }
366371

367372
private fun isValidStepClick(stepId: ProgressStepId): Boolean = when (stepId) {

0 commit comments

Comments
 (0)