fix(CodeTransformation): remove play button from bottom panel (#4194)

* fix(CodeTransformation): remove play/stop buttons from bottom panel

* remove extra files

* fix changelog

* add stop button back

* add jobId to metric

---------

Co-authored-by: David Hasani <[email protected]>

Author: dhasani23

.changes/next-release/removal-6d1b2bf1-ed21-467c-9333-13d062442906.json

@@ -0,0 +1,4 @@
+{
+  "type" : "removal",
+  "description" : "CodeTransformation: remove play button from Transformation Hub, instead use /transform in chat"
+}

gradle/libs.versions.toml

@@ -21,7 +21,7 @@ mockito = "5.10.0"
 mockitoKotlin = "5.2.1"
 mockk = "1.13.8"
 node-gradle = "7.0.1"
-telemetryGenerator = "1.0.196"
+telemetryGenerator = "1.0.197"
 testLogger = "3.1.0"
 testRetry = "1.5.2"
 # test-only; platform provides slf4j transitively at runtime. <233, 1.7.36; >=233, 2.0.9

plugins/toolkit/jetbrains-core/resources/META-INF/ext-java.xml

@@ -48,9 +48,6 @@
     </extensions>
     <actions>
         <group id="aws.toolkit.codemodernizer.toolbar">
-            <action
-                id="codemodernizer.toolbar.startmodernizer"
-                class="software.aws.toolkits.jetbrains.services.codemodernizer.actions.CodeModernizerStartModernizerAction"/>
             <action
                 id="codemodernizer.toolbar.stopmodernizer"
                 class="software.aws.toolkits.jetbrains.services.codemodernizer.actions.CodeModernizerStopModernizerAction"/>

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/CodeModernizerManager.kt

@@ -240,7 +240,7 @@ class CodeModernizerManager(private val project: Project) : PersistentStateCompo
         // New projectDetails metric should always be fired whether the project was valid or invalid
         CodetransformTelemetry.projectDetails(
             codeTransformSessionId = CodeTransformTelemetryState.instance.getSessionId(),
-            result = if (!validationResult.valid) Result.Failed else Result.Unknown,
+            result = if (!validationResult.valid) Result.Failed else Result.Succeeded,
             reason = if (!validationResult.valid) validationResult.invalidTelemetryReason.additonalInfo else null,
             codeTransformPreValidationError = validationResult.invalidTelemetryReason.category ?: CodeTransformPreValidationError.Unknown,
             codeTransformLocalJavaVersion = project.tryGetJdk().toString()
@@ -582,13 +582,7 @@ class CodeModernizerManager(private val project: Project) : PersistentStateCompo
         }
 
     fun informUserOfCompletion(result: CodeModernizerJobCompletedResult) {
-        CodetransformTelemetry.totalRunTime(
-            codeTransformSessionId = CodeTransformTelemetryState.instance.getSessionId(),
-            codeTransformResultStatusMessage = result.toString(),
-            codeTransformRunTimeLatency = calculateTotalLatency(CodeTransformTelemetryState.instance.getStartTime(), Instant.now()),
-            codeTransformLocalJavaVersion = getJavaVersionFromProjectSetting(project),
-            codeTransformLocalMavenVersion = getMavenVersion(project),
-        )
+        var jobId: JobId? = null
         when (result) {
             is CodeModernizerJobCompletedResult.UnableToCreateJob -> notifyJobFailure(
                 result.failureReason,
@@ -612,19 +606,25 @@ class CodeModernizerManager(private val project: Project) : PersistentStateCompo
                 listOf(displayFeedbackNotificationAction())
             )
 
-            is CodeModernizerJobCompletedResult.JobPartiallySucceeded -> notifyStickyInfo(
-                message("codemodernizer.notification.info.modernize_partial_complete.title"),
-                message("codemodernizer.notification.info.modernize_partial_complete.content", result.targetJavaVersion.description),
-                project,
-                listOf(displayDiffNotificationAction(result.jobId), displaySummaryNotificationAction(result.jobId), displayFeedbackNotificationAction()),
-            )
+            is CodeModernizerJobCompletedResult.JobPartiallySucceeded -> {
+                notifyStickyInfo(
+                    message("codemodernizer.notification.info.modernize_partial_complete.title"),
+                    message("codemodernizer.notification.info.modernize_partial_complete.content", result.targetJavaVersion.description),
+                    project,
+                    listOf(displayDiffNotificationAction(result.jobId), displaySummaryNotificationAction(result.jobId), displayFeedbackNotificationAction()),
+                )
+                jobId = result.jobId
+            }
 
-            is CodeModernizerJobCompletedResult.JobCompletedSuccessfully -> notifyStickyInfo(
-                message("codemodernizer.notification.info.modernize_complete.title"),
-                message("codemodernizer.notification.info.modernize_complete.content"),
-                project,
-                listOf(displayDiffNotificationAction(result.jobId), displaySummaryNotificationAction(result.jobId)),
-            )
+            is CodeModernizerJobCompletedResult.JobCompletedSuccessfully -> {
+                notifyStickyInfo(
+                    message("codemodernizer.notification.info.modernize_complete.title"),
+                    message("codemodernizer.notification.info.modernize_complete.content"),
+                    project,
+                    listOf(displayDiffNotificationAction(result.jobId), displaySummaryNotificationAction(result.jobId)),
+                )
+                jobId = result.jobId
+            }
 
             is CodeModernizerJobCompletedResult.ManagerDisposed -> LOG.warn { "Manager disposed" }
             is CodeModernizerJobCompletedResult.JobAbortedBeforeStarting -> LOG.warn { "Job was aborted" }
@@ -641,6 +641,14 @@ class CodeModernizerManager(private val project: Project) : PersistentStateCompo
                 listOf(openTroubleshootingGuideNotificationAction(TROUBLESHOOTING_URL_PREREQUISITES), displayFeedbackNotificationAction()),
             )
         }
+        CodetransformTelemetry.totalRunTime(
+            codeTransformJobId = jobId?.toString(),
+            codeTransformSessionId = CodeTransformTelemetryState.instance.getSessionId(),
+            codeTransformResultStatusMessage = result.toString(),
+            codeTransformRunTimeLatency = calculateTotalLatency(CodeTransformTelemetryState.instance.getStartTime(), Instant.now()),
+            codeTransformLocalJavaVersion = getJavaVersionFromProjectSetting(project),
+            codeTransformLocalMavenVersion = getMavenVersion(project),
+        )
     }
 
     fun createCodeModernizerSession(customerSelection: CustomerSelection, project: Project) = CodeModernizerSession(

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/actions/CodeModernizerStartModernizerAction.kt

@@ -536,9 +536,9 @@ codemodernizer.customerselectiondialog.found_supported_jdk=We found Java version
 codemodernizer.customerselectiondialog.found_unsupported_jdk=We found an unsupported Java version ({0}).
 codemodernizer.customerselectiondialog.ok_button=Transform
 codemodernizer.customerselectiondialog.title=Transform your application
-codemodernizer.explorer.show_active_job_history=Code Transform show active job details
+codemodernizer.explorer.show_active_job_history=Show job details
 codemodernizer.explorer.show_active_job_history_description=View your Code Transform active job details in the ToolWindow
-codemodernizer.explorer.show_job_history=Show Code Transform job history
+codemodernizer.explorer.show_job_history=Show job history
 codemodernizer.explorer.show_job_history_description=View your code transform job history and job details
 codemodernizer.explorer.show_transformation_plan_title=View your code transformation plan
 codemodernizer.explorer.show_transformation_summary_title=View your code transformation summary