replace buildDir deprecated calls

Author: samgst-amazon

buildSrc/src/main/kotlin/software/aws/toolkits/gradle/resources/ValidateMessages.kt

@@ -21,9 +21,9 @@ open class ValidateMessages : DefaultTask() {
     val paths: ConfigurableFileCollection = project.objects.fileCollection()
 
     @OutputFile
-    val output: RegularFileProperty = project.objects.fileProperty().convention {
-        project.buildDir.resolve("validateMessages")
-    }
+    val output: RegularFileProperty = project.objects.fileProperty().convention(
+        project.layout.buildDirectory.file("validateMessages")
+    )
 
     init {
         group = VERIFICATION_GROUP

plugins/amazonq/mynah-ui/build.gradle.kts

@@ -8,7 +8,7 @@ plugins {
 }
 
 // mynah build assumes 'build/' belongs to itself, which conflicts with gradle
-buildDir = file("gradle_build")
+layout.buildDirectory = file("gradle_build")
 
 val buildMynahUI = tasks.register<NpmTask>("buildMynahUI") {
     dependsOn(tasks.npmInstall)

plugins/core/resources/build.gradle.kts

@@ -12,7 +12,7 @@ plugins {
 
 sourceSets {
     main {
-        resources.srcDir("$buildDir/downloaded-resources")
+        resources.srcDir(layout.buildDirectory.dir("downloaded-resources"))
     }
 }
 
@@ -26,12 +26,13 @@ tasks.test {
 }
 
 val download = tasks.register<Download>("downloadResources") {
-    dest("$buildDir/downloaded-resources/software/aws/toolkits/resources/")
+    val resourcesDir = layout.buildDirectory.dir("downloaded-resources/software/aws/toolkits/resources/").get().asFile
+    dest(resourcesDir)
     src(listOf("https://idetoolkits.amazonwebservices.com/endpoints.json"))
     onlyIfModified(true)
     useETag(true)
     doFirst {
-        mkdir("$buildDir/downloaded-resources/software/aws/toolkits/resources/")
+        mkdir(resourcesDir)
     }
 }
 

plugins/core/sdk-codegen/build.gradle.kts

@@ -7,7 +7,7 @@ plugins {
 
 sdkGenerator {
     c2jFolder.set(file("$projectDir/codegen-resources"))
-    outputDir.set(file("$buildDir/generated-sources"))
+    outputDir.set(layout.buildDirectory.dir("generated-sources").get().asFile)
 }
 
 dependencies {

plugins/core/webview/build.gradle.kts

@@ -7,7 +7,7 @@ plugins {
     alias(libs.plugins.node.gradle)
 }
 
-buildDir = file("gradle_build")
+layout.buildDirectory = file("gradle_build")
 
 val buildGetStartUI = tasks.register<NpmTask>("buildWebviewUI") {
     dependsOn(tasks.npmInstall)

plugins/toolkit/jetbrains-core/build.gradle.kts

@@ -42,7 +42,7 @@ dependencies {
 
 val changelog = tasks.register<GeneratePluginChangeLog>("pluginChangeLog") {
     includeUnreleased.set(true)
-    changeLogFile.set(project.file("$buildDir/changelog/change-notes.xml"))
+    changeLogFile.set(project.layout.buildDirectory.file("changelog/change-notes.xml"))
 }
 
 tasks.compileJava {
@@ -113,7 +113,7 @@ val gatewayArtifacts by configurations.creating {
     extendsFrom(configurations["implementation"], configurations["runtimeOnly"])
 }
 
-val gatewayJar = tasks.create<Jar>("gatewayJar") {
+val gatewayJar = tasks.register<Jar>("gatewayJar") {
     // META-INF/plugin.xml is a duplicate?
     // unclear why the exclude() statement didn't work
     duplicatesStrategy = DuplicatesStrategy.WARN

plugins/toolkit/jetbrains-gateway/build.gradle.kts

@@ -137,7 +137,7 @@ val toolkitInstallationScripts = tasks.register<Tar>("generateTar") {
 
 val gatewayResourcesDir = tasks.register<Sync>("gatewayResourcesDir") {
     from("gateway-resources/caws-proxy-command.bat", toolkitInstallationScripts)
-    into("$buildDir/$name")
+    into(layout.buildDirectory.dir(name))
 
     includeEmptyDirs = false
 }

plugins/toolkit/jetbrains-rider/build.gradle.kts

@@ -94,7 +94,7 @@ apply<RdGenPlugin>()
 tasks.register<RdGenTask>("generateModels")
 
 val resharperPluginPath = File(projectDir, "ReSharper.AWS")
-val resharperBuildPath = File(project.buildDir, "dotnetBuild")
+val resharperBuildPath = layout.buildDirectory.dir("dotnetBuild").get().asFile
 
 val resharperParts = listOf(
     "AWS.Daemon",
@@ -257,7 +257,7 @@ val buildReSharperPlugin = tasks.register("buildReSharperPlugin") {
             "normal",
             "${resharperPluginPath.canonicalPath}/ReSharper.AWS.sln"
         )
-        exec {
+        project.providers.exec {
             executable = "dotnet"
             args = arguments
         }

ui-tests/build.gradle.kts

@@ -45,7 +45,7 @@ tasks.register<Test>("uiTestCore") {
     systemProperty("junit.jupiter.extensions.autodetection.enabled", true)
 
     systemProperty("testDataPath", project.rootDir.resolve("testdata").toString())
-    systemProperty("testReportPath", project.buildDir.resolve("reports").resolve("tests").resolve("testRecordings").toString())
+    systemProperty("testReportPath", layout.buildDirectory.dir("reports/tests/testRecordings").get().asFile.toString())
 
     systemProperty("GRADLE_PROJECT", "sandbox-all")
     useJUnitPlatform {