Skip to content

Commit df3d4fe

Browse files
committed
fix
1 parent 16d6978 commit df3d4fe

File tree

7 files changed

+4
-40
lines changed

7 files changed

+4
-40
lines changed

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QOpenPanelAction.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import software.aws.toolkits.telemetry.UiTelemetry
1515

1616
class QOpenPanelAction : AnAction(message("action.q.openchat.text"), null, AwsIcons.Logos.AWS_Q) {
1717
override fun actionPerformed(e: AnActionEvent) {
18-
if (isRunningOnRemoteBackend() || !isQSupportedInThisVersion()) return
18+
if (isRunningOnRemoteBackend()) return
1919
val project = e.getRequiredData(CommonDataKeys.PROJECT)
2020
UiTelemetry.click(project, "q_openChat")
2121
ToolWindowManager.getInstance(project).getToolWindow(AMAZON_Q_WINDOW_ID)?.activate(null, true)

plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/utils/CodeTransformSharedUtils.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import software.aws.toolkits.jetbrains.core.credentials.AwsBearerTokenConnection
99
import software.aws.toolkits.jetbrains.core.credentials.ToolkitConnectionManager
1010
import software.aws.toolkits.jetbrains.core.credentials.lazyIsUnauthedBearerConnection
1111
import software.aws.toolkits.jetbrains.core.credentials.pinning.QConnection
12-
import software.aws.toolkits.jetbrains.services.amazonq.isQSupportedInThisVersion
1312
import software.aws.toolkits.jetbrains.utils.isRunningOnRemoteBackend
1413
import java.time.Instant
1514

@@ -28,6 +27,6 @@ fun isValidCodeTransformConnection(project: Project): Boolean {
2827
}
2928
fun isCodeTransformAvailable(project: Project): Boolean {
3029
if (!isIntellij()) return false
31-
if (isRunningOnRemoteBackend() || !isQSupportedInThisVersion()) return false
30+
if (isRunningOnRemoteBackend()) return false
3231
return isValidCodeTransformConnection(project)
3332
}

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QSupportedUtil.kt

Lines changed: 0 additions & 11 deletions
This file was deleted.

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/services/telemetry/otel/OtelBase.kt

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33

44
package software.aws.toolkits.jetbrains.services.telemetry.otel
55

6-
import com.intellij.openapi.application.ApplicationInfo
76
import com.intellij.openapi.application.ApplicationManager
8-
import com.intellij.platform.diagnostic.telemetry.helpers.useWithoutActiveScope
97
import io.opentelemetry.api.common.AttributeKey
108
import io.opentelemetry.api.common.Attributes
119
import io.opentelemetry.api.trace.Span
@@ -53,17 +51,8 @@ abstract class AbstractSpanBuilder<
5351
* @inheritdoc
5452
*/
5553
inline fun<T> use(operation: (SpanType) -> T): T =
56-
// FIX_WHEN_MIN_IS_241: not worth fixing for 233
57-
if (ApplicationInfo.getInstance().build.baselineVersion == 233) {
58-
startSpan().useWithoutActiveScope { span ->
59-
span.makeCurrent().use {
60-
operation(span as SpanType)
61-
}
62-
}
63-
} else {
64-
startSpan().ijUse { span ->
65-
operation(span as SpanType)
66-
}
54+
startSpan().ijUse { span ->
55+
operation(span as SpanType)
6756
}
6857

6958
/**

plugins/toolkit/jetbrains-core/it/software/aws/toolkits/jetbrains/services/ecr/EcrPullIntegrationTest.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,4 @@ class EcrPullIntegrationTest {
8585
assertThat(serverRuntime.agent.getImages(null).firstOrNull { it.imageId == localImageId }).isNotNull()
8686
}
8787
}
88-
89-
// FIX_WHEN_MIN_IS_231: deleteImage() is blocking prior to 231
90-
private fun Unit.await() {}
9188
}

plugins/toolkit/jetbrains-core/it/software/aws/toolkits/jetbrains/services/lambda/java/JavaLocalLambdaRunConfigurationIntegrationTest.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ package software.aws.toolkits.jetbrains.services.lambda.java
55

66
import com.intellij.compiler.CompilerTestUtil
77
import com.intellij.execution.executors.DefaultDebugExecutor
8-
import com.intellij.openapi.application.ApplicationManager
9-
import com.intellij.testFramework.common.ThreadLeakTracker
108
import com.intellij.testFramework.runInEdtAndWait
119
import org.assertj.core.api.Assertions.assertThat
1210
import org.junit.After
@@ -57,9 +55,6 @@ class JavaLocalLambdaRunConfigurationIntegrationTest(private val runtime: Lambda
5755

5856
@Before
5957
fun setUp() {
60-
// FIX_WHEN_MIN_IS_241: jdk21 known offender: https://github.com/JetBrains/intellij-community/commit/1bdcfa5340969ba84c0ecf88d48f6e27d3de8a54
61-
ThreadLeakTracker.longRunningThreadCreated(ApplicationManager.getApplication(), "process reaper")
62-
6358
setSamExecutableFromEnvironment()
6459

6560
val fixture = projectRule.fixture

plugins/toolkit/jetbrains-core/tst/software/aws/toolkits/jetbrains/services/lambda/execution/sam/JavaSamRunningStateTest.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,10 @@
33

44
package software.aws.toolkits.jetbrains.services.lambda.execution.sam
55

6-
import com.intellij.openapi.application.ApplicationManager
76
import com.intellij.openapi.application.runWriteAction
87
import com.intellij.openapi.projectRoots.ProjectJdkTable
98
import com.intellij.openapi.roots.ProjectRootManager
109
import com.intellij.testFramework.IdeaTestUtil
11-
import com.intellij.testFramework.common.ThreadLeakTracker
1210
import com.intellij.testFramework.runInEdtAndGet
1311
import com.intellij.testFramework.runInEdtAndWait
1412
import org.assertj.core.api.Assertions.assertThat
@@ -44,9 +42,6 @@ class JavaSamRunningStateTest {
4442
projectRule.fixture
4543
credentialManager.addCredentials(mockCredsId)
4644

47-
// FIX_WHEN_MIN_IS_241: jdk21 known offender: https://github.com/JetBrains/intellij-community/commit/1bdcfa5340969ba84c0ecf88d48f6e27d3de8a54
48-
ThreadLeakTracker.longRunningThreadCreated(ApplicationManager.getApplication(), "process reaper")
49-
5045
val sdk = IdeaTestUtil.getMockJdk18()
5146
runInEdtAndWait {
5247
runWriteAction {

0 commit comments

Comments
 (0)