Skip to content

Commit f57ee05

Browse files
committed
rider
1 parent abc0d04 commit f57ee05

File tree

11 files changed

+50
-11
lines changed

11 files changed

+50
-11
lines changed
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
// Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved.
2+
// SPDX-License-Identifier: Apache-2.0
3+
4+
package base
5+
6+
abstract class BaseTestWithMarkup : com.jetbrains.rider.test.base.BaseTestWithMarkup() {
7+
abstract fun solutionDirectoryName(): String
8+
9+
override fun getSolutionDirectoryName() = solutionDirectoryName()
10+
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
// Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved.
2+
// SPDX-License-Identifier: Apache-2.0
3+
4+
package base
5+
6+
abstract class BaseTestWithSolution : com.jetbrains.rider.test.base.BaseTestWithSolution() {
7+
abstract fun solutionDirectoryName(): String
8+
9+
override fun getSolutionDirectoryName() = solutionDirectoryName()
10+
}
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
// Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved.
2+
// SPDX-License-Identifier: Apache-2.0
3+
4+
package base
5+
6+
abstract class BaseTestWithMarkup : com.jetbrains.rider.test.base.BaseTestWithMarkup() {
7+
abstract fun solutionDirectoryName(): String
8+
9+
override val testSolution: String
10+
get() = solutionDirectoryName()
11+
}
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
// Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved.
2+
// SPDX-License-Identifier: Apache-2.0
3+
4+
package base
5+
6+
abstract class BaseTestWithSolution : com.jetbrains.rider.test.base.BaseTestWithSolution() {
7+
abstract fun solutionDirectoryName(): String
8+
9+
override val testSolution: String
10+
get() = solutionDirectoryName()
11+
}

plugins/toolkit/jetbrains-rider/tst/base/AwsReuseSolutionTestBase.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
package base
55

66
import com.jetbrains.rider.projectView.solutionDirectory
7-
import com.jetbrains.rider.test.base.BaseTestWithSolution
87
import com.jetbrains.rider.test.debugger.XDebuggerTestHelper
98
import com.jetbrains.rider.test.scriptingApi.getVirtualFileFromPath
109
/**
@@ -16,8 +15,6 @@ abstract class AwsReuseSolutionTestBase : BaseTestWithSolution() {
1615
override val persistCaches: Boolean get() = false
1716
override val restoreNuGetPackages: Boolean get() = false
1817

19-
abstract override fun getSolutionDirectoryName(): String
20-
2118
// 15 is a magic number (it's the return statement since they are all the same), but the only
2219
// example of it used that I could find it is used that way:
2320
// https://github.com/JetBrains/fsharp-support/blob/93ab17493a34a0bc0fd4c70b11adde02f81455c4/rider-fsharp/src/test/kotlin/debugger/AsyncDebuggerTest.kt#L6

plugins/toolkit/jetbrains-rider/tst/software/aws/toolkits/jetbrains/services/lambda/completion/DotNetHandlerCompletionProviderTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import software.aws.toolkits.jetbrains.utils.OPEN_SOLUTION_DIR_NAME
1313

1414
class DotNetHandlerCompletionProviderTest : AwsReuseSolutionTestBase() {
1515

16-
override fun getSolutionDirectoryName(): String = OPEN_SOLUTION_DIR_NAME
16+
override fun solutionDirectoryName(): String = OPEN_SOLUTION_DIR_NAME
1717

1818
override val waitForCaches = true
1919

plugins/toolkit/jetbrains-rider/tst/software/aws/toolkits/jetbrains/services/lambda/completion/DotNetHandlerCompletionTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,21 @@
33

44
package software.aws.toolkits.jetbrains.services.lambda.completion
55

6+
import base.BaseTestWithSolution
67
import base.allowCustomDotnetRoots
78
import base.backendStartTimeout
89
import com.intellij.ui.icons.CachedImageIcon
910
import com.jetbrains.rd.ide.model.IconModel
1011
import com.jetbrains.rd.ui.icons.toIdeaIcon
1112
import com.jetbrains.rider.test.annotations.TestEnvironment
12-
import com.jetbrains.rider.test.base.BaseTestWithSolution
1313
import org.assertj.core.api.Assertions.assertThat
1414
import org.testng.annotations.BeforeSuite
1515
import org.testng.annotations.Test
1616
import software.aws.toolkits.jetbrains.utils.OPEN_SOLUTION_DIR_NAME
1717
import java.time.Duration
1818

1919
class DotNetHandlerCompletionTest : BaseTestWithSolution() {
20-
override fun getSolutionDirectoryName() = OPEN_SOLUTION_DIR_NAME
20+
override fun solutionDirectoryName() = OPEN_SOLUTION_DIR_NAME
2121

2222
override val backendLoadedTimeout: Duration = backendStartTimeout
2323

plugins/toolkit/jetbrains-rider/tst/software/aws/toolkits/jetbrains/services/lambda/dotnet/DotNetLambdaBuilderTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import software.aws.toolkits.jetbrains.services.lambda.sam.SamCommon
1313
import software.aws.toolkits.jetbrains.utils.OPEN_SOLUTION_DIR_NAME
1414

1515
class DotNetLambdaBuilderTest : AwsReuseSolutionTestBase() {
16-
override fun getSolutionDirectoryName(): String = OPEN_SOLUTION_DIR_NAME
16+
override fun solutionDirectoryName(): String = OPEN_SOLUTION_DIR_NAME
1717

1818
private val sut = DotNetLambdaBuilder()
1919

plugins/toolkit/jetbrains-rider/tst/software/aws/toolkits/jetbrains/services/lambda/dotnet/DotNetLambdaHandlerResolverTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import software.aws.toolkits.jetbrains.utils.OPEN_SOLUTION_DIR_NAME
1717
*/
1818
class DotNetLambdaHandlerResolverTest : AwsReuseSolutionTestBase() {
1919

20-
override fun getSolutionDirectoryName(): String = OPEN_SOLUTION_DIR_NAME
20+
override fun solutionDirectoryName(): String = OPEN_SOLUTION_DIR_NAME
2121

2222
@Test
2323
fun testHandler_SingleValidHandler() {

plugins/toolkit/jetbrains-rider/tst/software/aws/toolkits/jetbrains/services/lambda/dotnet/LambdaGutterMarkHighlightingTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33

44
package software.aws.toolkits.jetbrains.services.lambda.dotnet
55

6+
import base.BaseTestWithMarkup
67
import base.backendStartTimeout
78
import com.jetbrains.rdclient.testFramework.waitForDaemon
89
import com.jetbrains.rider.projectView.solution
9-
import com.jetbrains.rider.test.base.BaseTestWithMarkup
1010
import org.testng.annotations.DataProvider
1111
import org.testng.annotations.Test
1212
import software.aws.toolkits.jetbrains.protocol.awsSettingModel
@@ -20,7 +20,7 @@ class LambdaGutterMarkHighlightingTest : BaseTestWithMarkup() {
2020

2121
override val backendLoadedTimeout: Duration = backendStartTimeout
2222

23-
override fun getSolutionDirectoryName() = "SamHelloWorldApp"
23+
override fun solutionDirectoryName() = "SamHelloWorldApp"
2424

2525
@Test
2626
fun testClass_FunctionClass_Detected() = verifyLambdaGutterMark()

0 commit comments

Comments
 (0)