Bump detekt to 1.23.5 (#4105)

Author: rli

gradle/libs.versions.toml

@@ -4,7 +4,7 @@ assertJ = "3.20.2" # Upgrading leads to SAM errors: https://youtrack.jetbrains.c
 # match with <root>/settings.gradle.kts
 awsSdk = "2.20.111"
 commonmark = "0.17.1"
-detekt = "1.23.0"
+detekt = "1.23.5"
 intellijGradle = "1.13.2"
 intellijRemoteRobot = "0.11.21"
 jackson = "2.15.1"

jetbrains-core/src/software/aws/toolkits/jetbrains/core/gettingstarted/editor/GettingStartedTelemetryUtils.kt

@@ -20,9 +20,11 @@ fun getEnabledConnectionsForTelemetry(project: Project): Set<AuthFormId> {
     if (explorerConnection !is ActiveConnection.NotConnected) {
         if (explorerConnection.connectionType == ActiveConnectionType.IAM_IDC) {
             enabledConnections.add(AuthFormId.IDENTITYCENTER_EXPLORER)
-        } else enabledConnections.add(
-            AuthFormId.IAMCREDENTIALS_EXPLORER
-        )
+        } else {
+            enabledConnections.add(
+                AuthFormId.IAMCREDENTIALS_EXPLORER
+            )
+        }
     }
     val codeCatalystConnection = checkBearerConnectionValidity(project, BearerTokenFeatureSet.CODECATALYST) // Currently this will always be builder id
     if (codeCatalystConnection !is ActiveConnection.NotConnected) enabledConnections.add(AuthFormId.BUILDERID_CODECATALYST)
@@ -31,9 +33,11 @@ fun getEnabledConnectionsForTelemetry(project: Project): Set<AuthFormId> {
     if (codeWhispererConnection !is ActiveConnection.NotConnected) {
         if (codeWhispererConnection.connectionType == ActiveConnectionType.IAM_IDC) {
             enabledConnections.add(AuthFormId.IDENTITYCENTER_CODEWHISPERER)
-        } else enabledConnections.add(
-            AuthFormId.BUILDERID_CODEWHISPERER
-        )
+        } else {
+            enabledConnections.add(
+                AuthFormId.BUILDERID_CODEWHISPERER
+            )
+        }
     }
     return enabledConnections
 }

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/panels/managers/BuildProgressSplitterPanelManager.kt

@@ -185,7 +185,9 @@ class BuildProgressSplitterPanelManager(private val project: Project) :
                 currentState.removeAll { it.id == ProgressStepId.PLAN_STEP }
                 if (transformationPlanStepsMayAdded.isNullOrEmpty()) {
                     currentState
-                } else currentState + transformationPlanStepsMayAdded
+                } else {
+                    currentState + transformationPlanStepsMayAdded
+                }
             } else {
                 currentState
             }

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/codescan/listeners/CodeWhispererCodeScanEditorMouseMotionListener.kt

@@ -115,7 +115,13 @@ class CodeWhispererCodeScanEditorMouseMotionListener(private val project: Projec
             |${issue.suggestedFixes[0].code}
             |```
             |
-            |${if (isFixDescriptionAvailable) "|### ${message("codewhisperer.codescan.suggested_fix_description")}\n${issue.suggestedFixes[0].description}" else ""}
+            |${if (isFixDescriptionAvailable) {
+                "|### ${message(
+                    "codewhisperer.codescan.suggested_fix_description"
+                )}\n${issue.suggestedFixes[0].description}"
+            } else {
+                ""
+            }}
             """.trimMargin()
         } else {
             ""

jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererTelemetryService.kt

@@ -446,7 +446,9 @@ class CodeWhispererTelemetryService {
 
         return if (isEmpty) {
             CodewhispererPreviousSuggestionState.Empty
-        } else CodewhispererPreviousSuggestionState.Discard
+        } else {
+            CodewhispererPreviousSuggestionState.Discard
+        }
     }
 
     fun sendPerceivedLatencyEvent(

jetbrains-core/src/software/aws/toolkits/jetbrains/settings/DynamicResourcesConfigurable.kt

@@ -112,9 +112,10 @@ class DynamicResourcesConfigurable : BoundConfigurable(message("aws.settings.dyn
     }
 
     private fun CheckBoxList<*>.toggleAll(state: Boolean) {
-        (0 until model.size).forEach { idx ->
+        for (idx in 0..model.size - 1) {
             checkboxStateHandler(idx, state)
         }
+
         updateCheckboxList()
     }
 

jetbrains-core/tst/software/aws/toolkits/jetbrains/core/tools/ToolManagerTest.kt

@@ -440,7 +440,11 @@ class ToolManagerTest {
         }
 
         val type = createManagedToolMock(toolId) {
-            on { determineLatestVersion() } doAnswer Answer<Version> { latch.countDown(); postCheckLatch.await(); version }
+            on { determineLatestVersion() } doAnswer Answer<Version> {
+                latch.countDown()
+                postCheckLatch.await()
+                version
+            }
             on { toTool(eq(installPath)) } doReturn Tool(this.mock, toolBinary)
         }
 

jetbrains-core/tst/software/aws/toolkits/jetbrains/services/codewhisperer/importadder/CodeWhispererJavaImportAdderTest.kt

@@ -132,7 +132,8 @@ class CodeWhispererJavaImportAdderTest : CodeWhispererImportAdderTestBase(
         }
 
     override fun assertSameImport(import1: PsiElement, import2: PsiElement) {
-        import1 as PsiImportStatementBase; import2 as PsiImportStatementBase
+        import1 as PsiImportStatementBase
+        import2 as PsiImportStatementBase
         assertThat(import1.text).isEqualTo(import1.text)
     }
 }

jetbrains-core/tst/software/aws/toolkits/jetbrains/services/codewhisperer/importadder/CodeWhispererPythonImportAdderTest.kt

@@ -308,12 +308,14 @@ class CodeWhispererPythonImportAdderTest : CodeWhispererImportAdderTestBase(
     }
 
     override fun assertSameImport(import1: PsiElement, import2: PsiElement) {
-        import1 as PyImportStatementBase; import2 as PyImportStatementBase
+        import1 as PyImportStatementBase
+        import2 as PyImportStatementBase
         assertThat(import1::class.java).isEqualTo(import2::class.java)
         if (import1 is PyImportStatement) {
             import2 as PyImportStatement
         } else {
-            import1 as PyFromImportStatement; import2 as PyFromImportStatement
+            import1 as PyFromImportStatement
+            import2 as PyFromImportStatement
             assertThat(import1.importSourceQName.toString()).isEqualTo(import2.importSourceQName.toString())
         }
         assertThat(import1.fullyQualifiedObjectNames.toString()).isEqualTo(import2.fullyQualifiedObjectNames.toString())

jetbrains-core/tst/software/aws/toolkits/jetbrains/utils/ui/UiUtilsTest.kt

@@ -25,7 +25,10 @@ class UiUtilsTest {
         component.addQuickSelect(checkbox, runnable)
 
         val click = MouseEvent(component, MouseEvent.BUTTON1, 0, 0, 100, 100, 1, false)
-        component.mouseListeners.forEach { it.mousePressed(click); it.mouseReleased(click) }
+        component.mouseListeners.forEach {
+            it.mousePressed(click)
+            it.mouseReleased(click)
+        }
         assertThat(checkbox.isSelected).isTrue()
         verify(runnable).run()
     }