Add validation on startup (#4138)

* Chore - Add code transform validation on startup
---------

Co-authored-by: Nick Ardecky <[email protected]>

Author: damntrecky

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/CodeModernizerManager.kt

@@ -205,11 +205,11 @@ class CodeModernizerManager(private val project: Project) : PersistentStateCompo
             if (isModernizationInProgress.getAndSet(true)) return@launch
             val validationResult = validate(project)
             runInEdt {
+                sendValidationResultTelemetry(validationResult)
                 if (validationResult.valid) {
                     runModernize(validationResult.validatedBuildFiles) ?: isModernizationInProgress.set(false)
                 } else {
                     warnUnsupportedProject(validationResult.invalidReason)
-                    sendValidationResultTelemetry(validationResult)
                     isModernizationInProgress.set(false)
                 }
             }
@@ -224,15 +224,24 @@ class CodeModernizerManager(private val project: Project) : PersistentStateCompo
         )
     }
 
-    private fun sendValidationResultTelemetry(validationResult: ValidationResult) {
-        if (!validationResult.valid) {
+    private fun sendValidationResultTelemetry(validationResult: ValidationResult, onProjectFirstOpen: Boolean = false) {
+        // Old telemetry event to be fired only when users click on transform
+        if (!validationResult.valid && !onProjectFirstOpen) {
             CodetransformTelemetry.isDoubleClickedToTriggerInvalidProject(
                 codeTransformPreValidationError = validationResult.invalidTelemetryReason.category ?: CodeTransformPreValidationError.Unknown,
                 codeTransformSessionId = CodeTransformTelemetryState.instance.getSessionId(),
                 result = Result.Failed,
                 reason = validationResult.invalidTelemetryReason.additonalInfo
             )
         }
+        // New projectDetails metric should always be fired whether the project was valid or invalid
+        CodetransformTelemetry.projectDetails(
+            codeTransformSessionId = CodeTransformTelemetryState.instance.getSessionId(),
+            result = if (!validationResult.valid) Result.Failed else Result.Unknown,
+            reason = if (!validationResult.valid) validationResult.invalidTelemetryReason.additonalInfo else null,
+            codeTransformPreValidationError = validationResult.invalidTelemetryReason.category ?: CodeTransformPreValidationError.Unknown,
+            codeTransformLocalJavaVersion = project.tryGetJdk().toString()
+        )
     }
 
     fun stopModernize() {
@@ -442,15 +451,24 @@ class CodeModernizerManager(private val project: Project) : PersistentStateCompo
         }
     }
 
-    fun tryResumeJob() = projectCoroutineScope(project).launch {
+    fun tryResumeJob(onProjectFirstOpen: Boolean = false) = projectCoroutineScope(project).launch {
         try {
             val notYetResumed = isResumingJob.compareAndSet(false, true)
+            // If the job is already running, compareAndSet will return false because the expected
+            // behavior is that the job is not running when trying to resume
             if (!notYetResumed) {
                 return@launch
             }
 
             LOG.info { "Attempting to resume job, current state is: $managerState" }
             if (!managerState.flags.getOrDefault(StateFlags.IS_ONGOING, false)) return@launch
+
+            // Gather project details
+            if (onProjectFirstOpen) {
+                val validationResult = validate(project)
+                sendValidationResultTelemetry(validationResult, onProjectFirstOpen)
+            }
+
             val context = managerState.toSessionContext(project)
             val session = CodeModernizerSession(context)
             val lastJobId = managerState.getLatestJobId()

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/CodeModernizerSession.kt

@@ -286,7 +286,8 @@ class CodeModernizerSession(
                 codeTransformApiNames = CodeTransformApiNames.UploadZip,
                 codeTransformSessionId = CodeTransformTelemetryState.instance.getSessionId(),
                 codeTransformRunTimeLatency = calculateTotalLatency(uploadStartTime, Instant.now()),
-                codeTransformTotalByteSize = payload.length().toInt()
+                codeTransformTotalByteSize = payload.length().toInt(),
+                codeTransformRequestId = createUploadUrlResponse.responseMetadata().requestId()
             )
             LOG.warn { "Upload complete" }
         }

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/CodeModernizerStartupActivity.kt

@@ -14,6 +14,7 @@ class CodeModernizerStartupActivity : StartupActivity.DumbAware {
      */
     override fun runActivity(project: Project) {
         if (!isCodeModernizerAvailable(project)) return
-        CodeModernizerManager.getInstance(project).tryResumeJob()
+        val codeModernizerInstance = CodeModernizerManager.getInstance(project)
+        codeModernizerInstance.tryResumeJob(true)
     }
 }

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/cwc/controller/ChatController.kt

@@ -73,6 +73,7 @@ import software.aws.toolkits.jetbrains.services.cwc.messages.OnboardingPageInter
 import software.aws.toolkits.jetbrains.services.cwc.messages.QuickActionMessage
 import software.aws.toolkits.jetbrains.services.cwc.storage.ChatSessionStorage
 import software.aws.toolkits.resources.message
+import software.aws.toolkits.telemetry.CodeTransformStartSrcComponents
 import software.aws.toolkits.telemetry.CodetransformTelemetry
 import software.aws.toolkits.telemetry.CwsprChatCommandType
 import java.time.Instant
@@ -140,7 +141,7 @@ class ChatController private constructor(
         ApplicationManager.getApplication().invokeLater {
             runInEdt {
                 if (!isActive) {
-                    manager.validateAndStart()
+                    manager.validateAndStart(CodeTransformStartSrcComponents.ChatPrompt)
                 } else {
                     manager.getBottomToolWindow().show()
                 }