fix detekt

Author: David Hasani

.kotlin/sessions/kotlin-compiler-3716745130316675982.salive

@@ -124,6 +124,11 @@ class CodeTransformChatController(
         codeTransformChatHelper.sendChatInputEnabledMessage(message.tabId, false)
         codeTransformChatHelper.sendUpdatePlaceholderMessage(message.tabId, "Open a new tab to chat with Q")
 
+        // since we're prompting the user, their module(s) must be eligible for both types of transformations, so track how often this happens here
+        if (objective === "language upgrade" || objective === "sql conversion") {
+            telemetry.submitSelection(objective)
+        }
+
         when (objective) {
             "language upgrade" -> this.handleLanguageUpgrade()
             "sql conversion" -> this.handleSQLConversion()
@@ -346,7 +351,9 @@ class CodeTransformChatController(
                     addNewMessage(buildSQLMetadataValidationSuccessIntroChatContent())
                     addNewMessage(buildSQLMetadataValidationSuccessDetailsChatContent(metadataValidationResult))
                     addNewMessage(buildModuleSchemaFormIntroChatContent())
-                    addNewMessage(buildModuleSchemaFormChatContent(context.project, context.project.getJavaModulesWithSQL(), metadataValidationResult.schemaOptions))
+                    addNewMessage(
+                        buildModuleSchemaFormChatContent(context.project, context.project.getJavaModulesWithSQL(), metadataValidationResult.schemaOptions)
+                    )
                 }
                 val selection = CustomerSelection(
                     // for SQL conversions (no sourceJavaVersion), use dummy value of Java 8 so that startJob API can be called

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/controller/CodeTransformChatController.kt

@@ -9,7 +9,7 @@ import kotlin.time.toKotlinDuration
 
 data class JobHistoryItem(val moduleName: String?, val status: String, val startTime: Instant, val runTime: java.time.Duration, val jobId: String) {
     operator fun get(col: Int): Any = when (col) {
-        0 -> moduleName ?: ""
+        0 -> moduleName.orEmpty()
         1 -> status
         2 -> startTime
         3 -> runTime.toKotlinDuration().inWholeSeconds.seconds.toString()

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/model/JobHistoryItem.kt

@@ -28,7 +28,7 @@ fun buildState(context: CodeModernizerSessionContext, isJobOngoing: Boolean, job
     lastJobContext.putAll(
         setOf(
             JobDetails.LAST_JOB_ID to jobId.id,
-            JobDetails.CONFIGURATION_FILE_PATH to if (context.configurationFile != null) context.configurationFile!!.path else "",
+            JobDetails.CONFIGURATION_FILE_PATH to (context.configurationFile?.path ?: error("No configuration file store in the state")),
             JobDetails.TARGET_JAVA_VERSION to context.targetJavaVersion.description,
             JobDetails.SOURCE_JAVA_VERSION to context.sourceJavaVersion.description,
             JobDetails.CUSTOM_BUILD_COMMAND to context.customBuildCommand

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/state/CodeModernizerState.kt

@@ -564,7 +564,7 @@ code.aws.workspaces.short=Dev Environments
 codemodernizer.builderrordialog.description.title=Error occurred when building your project
 codemodernizer.chat.form.user_selection.item.choose_module=Choose a module to transform
 codemodernizer.chat.form.user_selection.item.choose_skip_tests_option=Choose to skip unit tests
-codemodernizer.chat.form.user_selection.item.choose_sql_metadata_file=Okay, I can convert the embedded SQL code for your Oracle to PostgreSQL migration. To get started, upload the zipped metadata file from your schema conversion in AWS DMS. To retrieve the metadata file: \n1. Open your database migration project in the AWS DMS console. \n2. Open the schema conversion and choose **Convert the embedded SQL in your application**. \n3. Choose the link to Amazon S3 console. You can download the metadata file from the {schema-conversion-project}/ directory.
+codemodernizer.chat.form.user_selection.item.choose_sql_metadata_file=Okay, I can convert the embedded SQL code for your Oracle to PostgreSQL transformation. To get started, upload the zipped metadata file from your schema conversion in AWS Data Migration Service (DMS). To retrieve the metadata file:\n1. Open your database migration project in the AWS DMS console.\n2. Open the schema conversion and choose **Convert the embedded SQL in your application**.\n3. Choose the link to Amazon S3 console.\n\nYou can download the metadata file from the {schema-conversion-project}/ directory. For more info, refer to the [documentation](https://docs.aws.amazon.com/dms/latest/userguide/schema-conversion-save-apply.html#schema-conversion-save).
 codemodernizer.chat.form.user_selection.item.choose_target_version=Choose the target code version
 codemodernizer.chat.form.user_selection.title=Q - Code transformation
 codemodernizer.chat.message.absolute_path_detected=I detected {0} potential absolute file path(s) in your {1} file: **{2}**. Absolute file paths might cause issues when I build your code. Any errors will show up in the build log.
@@ -575,7 +575,7 @@ codemodernizer.chat.message.button.hil_cancel=Cancel
 codemodernizer.chat.message.button.hil_submit=Submit
 codemodernizer.chat.message.button.open_file=Open file
 codemodernizer.chat.message.button.open_transform_hub=Open Transformation Hub
-codemodernizer.chat.message.button.select_sql_metadata=Upload metadata file
+codemodernizer.chat.message.button.select_sql_metadata=Select metadata file
 codemodernizer.chat.message.button.stop_transform=Stop transformation
 codemodernizer.chat.message.button.view_build=View build progress
 codemodernizer.chat.message.button.view_diff=View diff
@@ -622,7 +622,7 @@ codemodernizer.chat.message.skip_tests=I will build your module using `mvn test`
 codemodernizer.chat.message.skip_tests_form.response=Okay, I will {0} when building your module.
 codemodernizer.chat.message.skip_tests_form.run_tests=Run unit tests
 codemodernizer.chat.message.skip_tests_form.skip=Skip unit tests
-codemodernizer.chat.message.sql_metadata_success=I retrieved the following information from the schema conversion metadata you provided:
+codemodernizer.chat.message.sql_metadata_success=I found the following source database, target database, and host based on the schema conversion metadata you provided:
 codemodernizer.chat.message.sql_module_schema_prompt=To continue, choose the module and schema for this transformation.
 codemodernizer.chat.message.transform_begin=I'm starting to transform your code. It can take 10 to 30 minutes to upgrade your code, depending on the size of your module. To monitor progress, go to the Transformation Hub.
 codemodernizer.chat.message.transform_cancelled_by_user=I cancelled your transformation. If you want to start another transformation, choose **Start a new transformation**.