From 124fc04a98a8d574540affa5f44619f193081957 Mon Sep 17 00:00:00 2001 From: Richard Li Date: Thu, 26 Sep 2024 17:33:35 -0700 Subject: [PATCH] Fix 404 on SSO callback handler Browsers would attempt to request `favicon.ico` which fail all request chains, leading to fallback to `BuiltInWebServer`/`DefaultWebServerPathHandler`. This would be fine, except the platform webserver respects the browser's `Connection: keep-alive` flag and keep the Netty channel open, and subsequent requests to `.../oauthCallback/...` get handled by `DefaultWebServerPathHandler` and always return 404. --- .../bugfix-10275db3-073a-4531-8559-98071108341f.json | 4 ++++ .../jetbrains-community/resources/oauthCallback/index.html | 1 + 2 files changed, 5 insertions(+) create mode 100644 .changes/next-release/bugfix-10275db3-073a-4531-8559-98071108341f.json diff --git a/.changes/next-release/bugfix-10275db3-073a-4531-8559-98071108341f.json b/.changes/next-release/bugfix-10275db3-073a-4531-8559-98071108341f.json new file mode 100644 index 00000000000..4c96ac4edac --- /dev/null +++ b/.changes/next-release/bugfix-10275db3-073a-4531-8559-98071108341f.json @@ -0,0 +1,4 @@ +{ + "type" : "bugfix", + "description" : "Fix issue where multiple SSO login attempts in a short time result in 404" +} \ No newline at end of file diff --git a/plugins/core/jetbrains-community/resources/oauthCallback/index.html b/plugins/core/jetbrains-community/resources/oauthCallback/index.html index 1b8478f11c4..4969eb9d06b 100644 --- a/plugins/core/jetbrains-community/resources/oauthCallback/index.html +++ b/plugins/core/jetbrains-community/resources/oauthCallback/index.html @@ -8,6 +8,7 @@ AWS Authentication +