Skip to content

Conversation

@samgst-amazon
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

-- Remove popup prompting users that signing out will delete the credential from config
-- Remove code that deletes the credential from config entirely

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Oct 9, 2024

Qodana Community for JVM

17 new problems were found

Inspection name Severity Problems
Companion object in extensions 🔶 Warning 7
Extension class should be final and non-public 🔶 Warning 7
Usage of redundant or deprecated syntax or deprecated symbols 🔶 Warning 1
Unused import directive 🔶 Warning 1
Unused symbol 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Will-ShaoHua and others added 9 commits October 8, 2024 20:12
…rd events for telemetry. (#4951)

* Adding Acceptance metrics for UTG
* fix(dev): add error messages for upload URL expiry

* Update .changes/next-release/bugfix-caf370b9-c943-4ece-a4c0-81bcefa7a4f5.json

Co-authored-by: Richard Li <[email protected]>

---------

Co-authored-by: Richard Li <[email protected]>
* Add signout metric

* Fix broken sign out
…mConfig' into samgst/stopDeletingCredentialFromConfig

# Conflicts:
#	plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/actions/SsoLogoutAction.kt
@samgst-amazon samgst-amazon deleted the samgst/stopDeletingCredentialFromConfig branch November 29, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants