refactor(amazonq) refactor ProjectContextProvider.kt and add tests #4988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-ShaoHua
commented
Oct 21, 2024
Comment on lines
-56
to
-60
| data class IndexRequestPayload( | ||
| val filePaths: List<String>, | ||
| val projectRoot: String, | ||
| val refresh: Boolean, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Will-ShaoHua
commented
Oct 21, 2024
Comment on lines
-67
to
-73
| data class QueryRequestPayload( | ||
| val query: String, | ||
| ) | ||
|
|
||
| data class UpdateIndexRequestPayload( | ||
| val filePath: String, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
rli
approved these changes
Oct 21, 2024
| private fun createMockServer() = WireMockRule(wireMockConfig().dynamicPort()) | ||
| } | ||
|
|
||
| val validQueryChatResponse = """ |
Contributor
There was a problem hiding this comment.
can you reformat the JSON blobs
Suggested change
| val validQueryChatResponse = """ | |
| // language=JSON | |
| val validQueryChatResponse = """ |
Contributor
Author
There was a problem hiding this comment.
@rli what does // language=JSON mean here
Contributor
Author
There was a problem hiding this comment.
isee, it tells IDE to treat it as JSON instead plain string
...unity/src/software/aws/toolkits/jetbrains/services/amazonq/project/ProjectContextProvider.kt
Show resolved
Hide resolved
leigaol
approved these changes
Oct 21, 2024
Will-ShaoHua
commented
Oct 21, 2024
| } | ||
|
|
||
| fun updateIndex(filePath: String) { | ||
| if (!isIndexComplete.get()) return |
Contributor
Author
There was a problem hiding this comment.
should remove this line.
leigaol
reviewed
Oct 21, 2024
|
|
||
| fun index(): Boolean { | ||
| logger.info { "project context: indexing ${project.name} on port ${encoderServer.port}" } | ||
| val projectRoot = project.guessProjectDir()?.path ?: return false |
Contributor
There was a problem hiding this comment.
regression. Please fix ASAP
leigaol
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick from #4976
Description
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.