feat(amazonq): support in editor chat #5004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...-community/src/software/aws/toolkits/jetbrains/services/cwc/inline/InlineChatPopupFactory.kt
Show resolved
Hide resolved
rli
reviewed
Oct 23, 2024
plugins/core/sdk-codegen/codegen-resources/codewhispererruntime/service-2.json
Show resolved
Hide resolved
grant0417
approved these changes
Oct 28, 2024
rli
reviewed
Oct 28, 2024
plugins/amazonq/chat/jetbrains-community/resources/META-INF/plugin-chat.xml
Show resolved
Hide resolved
...ns-community/src/software/aws/toolkits/jetbrains/services/cwc/inline/InlineChatPopupPanel.kt
Fixed
Show fixed
Hide fixed
...hared/jetbrains-community/resources/software/aws/toolkits/resources/AmazonQBundle.properties
Show resolved
Hide resolved
...ns-community/src/software/aws/toolkits/jetbrains/services/cwc/inline/InlineChatController.kt
Outdated
Show resolved
Hide resolved
...ns-community/src/software/aws/toolkits/jetbrains/services/cwc/inline/InlineChatController.kt
Outdated
Show resolved
Hide resolved
...ns-community/src/software/aws/toolkits/jetbrains/services/cwc/inline/InlineChatController.kt
Show resolved
Hide resolved
Contributor
|
is there tracking item for tests |
Contributor
Author
Will and a SIM to track the tests |
...c/software/aws/toolkits/jetbrains/services/cwc/editor/context/file/util/LanguageExtractor.kt
Outdated
Show resolved
Hide resolved
Will-ShaoHua
approved these changes
Oct 28, 2024
rli
reviewed
Oct 28, 2024
Comment on lines
+119
to
+126
| private val popupSubmitHandler: suspend (String, String, Int, Editor) -> String = { | ||
| prompt: String, selectedCode: String, selectedLineStart: Int, editor: Editor -> | ||
| runBlocking { | ||
| isInProgress.set(true) | ||
| val message = handleChat(prompt, selectedCode, editor, selectedLineStart) | ||
| message | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| private val popupSubmitHandler: suspend (String, String, Int, Editor) -> String = { | |
| prompt: String, selectedCode: String, selectedLineStart: Int, editor: Editor -> | |
| runBlocking { | |
| isInProgress.set(true) | |
| val message = handleChat(prompt, selectedCode, editor, selectedLineStart) | |
| message | |
| } | |
| } | |
| private val popupSubmitHandler: suspend (String, String, Int, Editor) -> String = { | |
| prompt, selectedCode, selectedLineStart, editor -> | |
| isInProgress.set(true) | |
| val message = handleChat(prompt, selectedCode, editor, selectedLineStart) | |
| message | |
| } |
or
Suggested change
| private val popupSubmitHandler: suspend (String, String, Int, Editor) -> String = { | |
| prompt: String, selectedCode: String, selectedLineStart: Int, editor: Editor -> | |
| runBlocking { | |
| isInProgress.set(true) | |
| val message = handleChat(prompt, selectedCode, editor, selectedLineStart) | |
| message | |
| } | |
| } | |
| private suspend fun popupSubmitHandler(prompt: String, selectedCode: String, selectedLineStart: Int, editor: Editor): String { | |
| isInProgress.set(true) | |
| val message = handleChat(prompt, selectedCode, editor, selectedLineStart) | |
| return message | |
| } |
and then you should be able to do
InlineChatPopupFactory(
submitHandler = ::popupSubmitHandler,
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
users will be able to chat with Q in editor by using command/ctrl + I to bring up chat popup, get code diff in editor and accept/reject diff
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.