feat(amazon q): adding support to accept java 17 projects #5018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
approved these changes
Oct 31, 2024
Contributor
rli
left a comment
rli
left a comment
There was a problem hiding this comment.
is the idea supporting rewrites into modern syntax?
Contributor
|
@rli idea is more so upgrading dependencies to the latest version, even if you're already using Java 17 |
Contributor
|
Waiting to approve once we complete the 1) string updates and 2) E2E testing |
ntarakad-aws
force-pushed
the
jdk17_source
branch
from
b25d6be to
7d01e52
Compare
dhasani23
reviewed
Nov 7, 2024
| codemodernizer.notification.warn.invalid_project.description.reason.no_valid_files=None of your open modules are supported for code transformation with Amazon Q. A pom.xml is required for transformation. Amazon Q can upgrade Java 8, Java 11, and Java 17 projects built on Maven. | ||
| codemodernizer.notification.warn.invalid_project.description.reason.not_logged_in=Amazon Q cannot start the transformation as you are not logged in with Identity Center or Builder ID. Also ensure that you are not using IntelliJ version 232.8660.185 and that you are not developing on a remote host (uncommon). | ||
| codemodernizer.notification.warn.invalid_project.description.reason.remote_backend=None of your open modules are supported by Amazon Q Code Transformation. Currently, Amazon Q can only upgrade Java 8 or Java 11 projects built on Maven, and cannot upgrade projects running on a remote host. | ||
| codemodernizer.notification.warn.invalid_project.description.reason.remote_backend=None of your open modules are supported for code transformation with Amazon Q. Amazon Q can't transform projects running on a remote host. |
Contributor
There was a problem hiding this comment.
I believe characters such as the single apostrophe need to be escaped with a \ otherwise they will not show up, you can test this to confirm, you'll probably see cant instead of can't without the \
Contributor
Author
There was a problem hiding this comment.
Looks like we use "cannot" so I can change to this
dhasani23
reviewed
Nov 13, 2024
| `Welcome to Code Transformation! | ||
| I can help you upgrade your Java 8 and 11 codebases to Java 17. | ||
| I can help you upgrade your Java 8 and Java 11 codebases to Java 17, or upgrade Java 17 code with up to date libraries and other dependencies.. |
Contributor
There was a problem hiding this comment.
Because of DMS work, I actually had to remove this sentence, so can you just make this Welcome to Code Transformation!
dhasani23
reviewed
Nov 13, 2024
| { | ||
| command: '/transform', | ||
| description: 'Transform your Java 8 or 11 Maven project to Java 17', | ||
| description: 'Transform your Java 8, Java 11, or Java 17 Maven projects', |
Contributor
There was a problem hiding this comment.
Same as below, can we make this Transform your Java project since that's what we're using for DMS
ntarakad-aws
force-pushed
the
jdk17_source
branch
from
7d01e52 to
cc90325
Compare
dhasani23
reviewed
Nov 14, 2024
| codemodernizer.chat.message.validation.error.no_pom=Sorry, I couldn't find a module that I can upgrade. I couldn't find a pom.xml file in any of your open projects. Currently, I can only upgrade Java 8 or Java 11 projects built on Maven. | ||
| codemodernizer.chat.message.validation.error.other=Sorry, I couldn't find a module that I can upgrade. Currently, I can only upgrade Java 8 or Java 11 projects built on Maven. If you have a Java 8 or Java 11 module in your workspace, you might need to configure your project so that I can find it. Go to File and choose Project Structure. In the Projects tab, set the correct project JDK and the correct language level. In the Modules tab, set the correct module JDK and language level. | ||
| codemodernizer.chat.message.validation.error.unsupported_java_version=Sorry, I couldn't find a module that I can upgrade. Currently, I can only upgrade Java 8 or Java 11 modules built on Maven. If you have a Java 8 or Java 11 module in your workspace, you might need to configure your project so that I can find it. Go to File and choose Project Structure. In the Projects tab, set the correct project JDK and the correct language level. In the Modules tab, set the correct module JDK and language level. | ||
| codemodernizer.chat.message.validation.error.no_pom=I couldn't find a module that I can upgrade. Your Java project must be built on Maven and contain a pom.xml file. For more information, see the Amazon Q documentation. |
Contributor
There was a problem hiding this comment.
Typically when we say "Amazon Q documentation" we hyperlink to it, see line 634 above for example
dhasani23
reviewed
Nov 14, 2024
| { | ||
| command: '/transform', | ||
| description: 'Transform your Java 8 or 11 Maven project to Java 17', | ||
| description: 'Transform your Java Project', |
Contributor
There was a problem hiding this comment.
nit: lowercase p in project
ntarakad-aws
force-pushed
the
jdk17_source
branch
from
cc90325 to
b2d93b4
Compare
ntarakad-aws
force-pushed
the
jdk17_source
branch
from
b2d93b4 to
cdfdb84
Compare
dhasani23
approved these changes
Nov 14, 2024
dhasani23
added a commit
to ntarakad-aws/aws-toolkit-jetbrains
that referenced
this pull request
Nov 18, 2024
* adding support to accept java 17 projects * confirmation of ui text received * fix minor text * fixing minor text comments * adding link to error message --------- Co-authored-by: David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
New Feature
Description
Enabling support for java 17 projects
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.