Skip to content

Conversation

@zixlin7
Copy link
Contributor

@zixlin7 zixlin7 commented Oct 29, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

  • promote the action for now for default key bindings until product researches to see if there is a better key binding we can adopt
  • bundle in apache common text

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zixlin7 zixlin7 requested review from a team as code owners October 29, 2024 20:49
Copy link
Contributor

@rli rli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs changelog

@zixlin7 zixlin7 requested review from bryceitoc9 and rli October 29, 2024 21:32
import com.intellij.openapi.keymap.KeymapUtil
import com.intellij.openapi.util.SystemInfo

class InlineChatActionPromoter : ActionPromoter {

Check warning

Code scanning / QDJVMC

Extension class should be final and non-public Warning

Extension class should not be public
@zixlin7 zixlin7 requested a review from manodnyab October 29, 2024 23:45
zixlin7 and others added 2 commits October 29, 2024 16:55
…kits/jetbrains/services/cwc/inline/InlineChatActionPromoter.kt

Co-authored-by: Richard Li <[email protected]>
@zixlin7 zixlin7 enabled auto-merge (squash) October 30, 2024 00:20
@zixlin7 zixlin7 merged commit 5d1de02 into aws:main Oct 30, 2024
12 of 13 checks passed
@zixlin7 zixlin7 deleted the fixKeyBinding branch October 30, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants