fix(amazonq): Fix for File Review payload and payload generation error for test and review #5166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nore regex pattern error handling.
laileni-aws
approved these changes
Dec 5, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...s-community/src/software/aws/toolkits/jetbrains/services/amazonq/FeatureDevSessionContext.kt
Fixed
Show fixed
Hide fixed
Contributor
|
please address automation comment |
rli
approved these changes
Dec 5, 2024
Comment on lines
+89
to
+91
| parseGitIgnore().mapNotNull { pattern -> | ||
| runCatching { Regex(pattern) }.getOrNull() | ||
| }.let { addAll(it) } |
Contributor
There was a problem hiding this comment.
can be simplified more but sure
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 17, 2025
…r for test and review (aws#5166) * Fix for code diff for file review to include only file path and gitignore regex pattern error handling. * Addition of changelog * Fix to simplify try and catch block. --------- Co-authored-by: Laxman Reddy <[email protected]>
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 22, 2025
…r for test and review (aws#5166) * Fix for code diff for file review to include only file path and gitignore regex pattern error handling. * Addition of changelog * Fix to simplify try and catch block. --------- Co-authored-by: Laxman Reddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Fix for File Review payload and payload generation error for test and review
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.