fix(amazonq): clicking on generated test file does not open file diff #5196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerated test file
ctlai95
changed the title
ctlai95
reviewed
Dec 11, 2024
| break | ||
| case 'codetest': | ||
| this.codeTestChatConnector.onFileClick(tabID, filePath, deleted, messageId) | ||
| this.codeTestChatConnector.onFormButtonClick(tabID, messageId ?? '', {id: "utg_view_diff"}) |
Contributor
There was a problem hiding this comment.
This is fine for now but can you please add a TODO to clean this up? Ideally codeTestChatConnector should have a method called onOpenDiff instead of calling onFormButtonClick which should only be used by form buttons.
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 17, 2025
…aws#5196) Updated the connector so that when a user clicks on the generated file, it now triggers the same functionality as clicking the "View Diff" button.
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 22, 2025
…aws#5196) Updated the connector so that when a user clicks on the generated file, it now triggers the same functionality as clicking the "View Diff" button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nerated test file
Types of changes
Description
Fix the issue that user can not open the file diff by clicking the generated test file.
Implementation
I updated the connector so that when a user clicks on the generated file, it now triggers the same functionality as clicking the "View Diff" button.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.