Skip to content

Conversation

@ctlai95
Copy link
Contributor

@ctlai95 ctlai95 commented Dec 17, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Scan scopes are not mapped correctly to the telemetry scope. It should be:

  1. /review, project scope: PROJECT
  2. /review, file scope: FILE_ON_DEMAND
  3. Auto-review: FILE_AUTO

We are also missing source=chat to indicate that the scan originated from chat.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ctlai95 ctlai95 marked this pull request as ready for review January 3, 2025 20:30
@ctlai95 ctlai95 requested a review from a team as a code owner January 3, 2025 20:30
@ctlai95 ctlai95 merged commit fdfc07c into aws:main Jan 3, 2025
11 checks passed
@ctlai95 ctlai95 deleted the fix-telemetry branch January 3, 2025 20:32
karanA-aws pushed a commit to karanA-aws/aws-toolkit-jetbrains that referenced this pull request Jan 17, 2025
karanA-aws pushed a commit to karanA-aws/aws-toolkit-jetbrains that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants