fix(amazonq): Skip including deleted files for FeatureDev context. #5228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilk-aws
approved these changes
Jan 6, 2025
manodnyab
approved these changes
Jan 6, 2025
ctidd
force-pushed
the
ctidd/nosuchfile
branch
from
56dea26 to
ef18cbe
Compare
eamonnfaherty
pushed a commit
to eamonnfaherty/aws-toolkit-jetbrains
that referenced
this pull request
Jan 7, 2025
…ws#5228) Co-authored-by: C Tidd <[email protected]>
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 17, 2025
…ws#5228) Co-authored-by: C Tidd <[email protected]>
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 22, 2025
…ws#5228) Co-authored-by: C Tidd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue when files are deleted while preparing context.
Types of changes
Description
Problem: When zipping context for
/dev, customer build processes (file watchers, etc.) may delete build artifacts we’ve already enumerated but have not added to the archive. As a best practice, customers should.gitignorethese types of files, but in the event they don't, this has the potential to block/devfrom running.Solution: Skip affected files, which are not found when adding to zip context for Feature Dev.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.