Fix(core): State storage roaming type set to default for notification components #5233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
manodnyab
approved these changes
Jan 7, 2025
eamonnfaherty
pushed a commit
to eamonnfaherty/aws-toolkit-jetbrains
that referenced
this pull request
Jan 7, 2025
… components (aws#5233) * set roaming type to default for Notification state utils * set roaming type to default for Notification state utils
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 17, 2025
… components (aws#5233) * set roaming type to default for Notification state utils * set roaming type to default for Notification state utils
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 22, 2025
… components (aws#5233) * set roaming type to default for Notification state utils * set roaming type to default for Notification state utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Since notification state utils are being stored in aws.xml, they need to have the same roaming type as other state components (which default to roamingType.DEFAULT):
If there are multiple components that store state in the same file, they must have the same roamingType attribute value.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.