Skip to content

Conversation

@ashishrp-aws
Copy link
Contributor

@ashishrp-aws ashishrp-aws commented Jan 8, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

/test fails for files outside of project scope because of service side failures due to path discrepancies. This fix will redirect the unit test generation for such files using conversation APIs in chat instead of running /test workflow.

Added override telemetry metrics. Will amend and add the metrics in toolkit-common once VSCode also merges.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashishrp-aws ashishrp-aws requested review from a team as code owners January 8, 2025 02:30
@ctlai95 ctlai95 changed the title fix(amazonq): fix for /test for files outside project scope. fix(amazonq): /test fails for files outside project scope Jan 8, 2025
@ashishrp-aws
Copy link
Contributor Author

/retryBuilds

@chungjac chungjac self-requested a review January 8, 2025 21:57
@ashishrp-aws ashishrp-aws enabled auto-merge (squash) January 8, 2025 22:35
@ashishrp-aws ashishrp-aws merged commit 291be07 into aws:main Jan 8, 2025
11 checks passed
@ashishrp-aws ashishrp-aws deleted the failure-fix branch January 9, 2025 04:13
karanA-aws pushed a commit to karanA-aws/aws-toolkit-jetbrains that referenced this pull request Jan 17, 2025
* fix for /test for files outside project scope.

* Added Telemetry metrics.

* Fix for build failure

* Renamed metric isSupportedFile to isFileInWorkspace

* Correction in description.

* Update .changes/next-release/bugfix-8c6afa32-afe4-41f2-a216-10d8bf5e2486.json

Co-authored-by: Tai Lai <[email protected]>

* Update plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt

Co-authored-by: Tai Lai <[email protected]>

* Update CodeTestChatController.kt

* detekt errors fix.

---------

Co-authored-by: Tai Lai <[email protected]>
karanA-aws pushed a commit to karanA-aws/aws-toolkit-jetbrains that referenced this pull request Jan 22, 2025
* fix for /test for files outside project scope.

* Added Telemetry metrics.

* Fix for build failure

* Renamed metric isSupportedFile to isFileInWorkspace

* Correction in description.

* Update .changes/next-release/bugfix-8c6afa32-afe4-41f2-a216-10d8bf5e2486.json

Co-authored-by: Tai Lai <[email protected]>

* Update plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt

Co-authored-by: Tai Lai <[email protected]>

* Update CodeTestChatController.kt

* detekt errors fix.

---------

Co-authored-by: Tai Lai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants