From 79dc95f75e5f24724df15ec04989f14c8083cc4a Mon Sep 17 00:00:00 2001 From: Randall-Jiang Date: Wed, 15 Jan 2025 13:31:07 -0800 Subject: [PATCH 1/2] telemetry: fix the unknown language issue --- .../amazonqCodeTest/controller/CodeTestChatController.kt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt b/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt index 9abaf0e5d27..dc862f2b8da 100644 --- a/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt +++ b/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt @@ -485,11 +485,16 @@ class CodeTestChatController( numberOfLinesSelected = selectedFileContent.lines().size lineDifference = numberOfLinesGenerated - numberOfLinesSelected + + // Character difference calculation: charsOfCodeGenerated = number of characters in generated test file - number of characters in original test file numberOfCharsGenerated = generatedFileContent.length numberOfCharsSelected = selectedFileContent.length charDifference = numberOfCharsGenerated - numberOfCharsSelected + println("lineDifference" + lineDifference) + println("charDifference" + charDifference) + session.linesOfCodeGenerated = lineDifference.coerceAtLeast(0) session.charsOfCodeGenerated = charDifference.coerceAtLeast(0) session.latencyOfTestGeneration = (Instant.now().toEpochMilli() - session.startTimeOfTestGeneration) From 0766e6355d567d8a5dced367f5d42c062b5adcdc Mon Sep 17 00:00:00 2001 From: Randall-Jiang Date: Wed, 15 Jan 2025 14:09:41 -0800 Subject: [PATCH 2/2] telemetry fix the unknown language issue and remove the wrong print --- .../amazonqCodeTest/controller/CodeTestChatController.kt | 5 ----- .../amazonqCodeTest/storage/ChatSessionStorage.kt | 9 ++------- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt b/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt index dc862f2b8da..9abaf0e5d27 100644 --- a/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt +++ b/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt @@ -485,16 +485,11 @@ class CodeTestChatController( numberOfLinesSelected = selectedFileContent.lines().size lineDifference = numberOfLinesGenerated - numberOfLinesSelected - - // Character difference calculation: charsOfCodeGenerated = number of characters in generated test file - number of characters in original test file numberOfCharsGenerated = generatedFileContent.length numberOfCharsSelected = selectedFileContent.length charDifference = numberOfCharsGenerated - numberOfCharsSelected - println("lineDifference" + lineDifference) - println("charDifference" + charDifference) - session.linesOfCodeGenerated = lineDifference.coerceAtLeast(0) session.charsOfCodeGenerated = charDifference.coerceAtLeast(0) session.latencyOfTestGeneration = (Instant.now().toEpochMilli() - session.startTimeOfTestGeneration) diff --git a/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/storage/ChatSessionStorage.kt b/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/storage/ChatSessionStorage.kt index 0a9a782ecb1..0e38f06c6de 100644 --- a/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/storage/ChatSessionStorage.kt +++ b/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/storage/ChatSessionStorage.kt @@ -8,13 +8,8 @@ import software.aws.toolkits.jetbrains.services.amazonqCodeTest.session.Session class ChatSessionStorage { private val sessions = mutableMapOf() - private fun createSession(tabId: String): Session { - val session = Session(tabId) - sessions[tabId] = session - return session - } - - fun getSession(tabId: String): Session = sessions[tabId] ?: createSession(tabId) + @Synchronized + fun getSession(tabId: String): Session = sessions.getOrPut(tabId) { Session(tabId) } fun deleteSession(tabId: String) { sessions.remove(tabId)