Skip to content

fix(generic chat): fix chat panel open-settings not opening the configuration panel correctly #5286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rli merged 2 commits into from
Jan 22, 2025
Merged

fix(generic chat): fix chat panel open-settings not opening the configuration panel correctly #5286

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
334338a
fix chat panel open-settings not opening the configuration panel corr…
Will-ShaoHua Jan 21, 2025
c86e2e2
Merge branch 'main' into chat-button
zixlin7 Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 9 additions & 31 deletions plugins/amazonq/mynah-ui/src/mynah-ui/ui/connector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,15 @@ export class Connector {
this.amazonqCommonsConnector.onCustomFormAction(tabId, action)
break
}
case 'cwc': {
if (action.id === `open-settings`) {
this.sendMessageToExtension({
command: 'open-settings',
type: '',
tabType: 'cwc',
})
}
}
}
}

Expand Down Expand Up @@ -594,35 +603,4 @@ export class Connector {
break
}
}

onFormButtonClick = (
tabId: string,
messageId: string,
action: {
id: string
text?: string
formItemValues?: Record<string, string>
}
) => {
if (isFormButtonCodeTransform(action.id)) {
this.codeTransformChatConnector.onFormButtonClick(tabId, action)
} else if (isFormButtonCodeScan(action.id)) {
this.codeScanChatConnector.onFormButtonClick(tabId, action)
} else if (isFormButtonCodeTest(action.id)) {
this.codeTestChatConnector.onFormButtonClick(tabId, messageId, action)
} else if (action.id === 'doc') {
this.docChatConnector.onFormButtonClick(tabId, action)
}
Comment on lines -607 to -615
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Jan 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wasmoved to here since RIV https://github.com/aws/aws-toolkit-jetbrains/pull/5286/files#diff-b5589403179a83b21f2b80bb57e8ab810c218b57327eaf711f494c033a790ba9L545-L561

switch (this.tabsStorage.getTab(tabId)?.type) {
case 'cwc':
if (action.id === `open-settings`) {
this.sendMessageToExtension({
command: 'open-settings',
type: '',
tabType: 'cwc',
})
}
break
}
}
}
Loading