Fix: add disposable to messageBus.connect() usage #5294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
rli
reviewed
Jan 23, 2025
Comment on lines
40
to
42
| class AmazonQToolWindowFactory( | ||
| private val disposable: Disposable, | ||
| ) : ToolWindowFactory, DumbAware { |
Contributor
There was a problem hiding this comment.
i don't believe the platform supports injecting the disposable like this. ToolWindowFactory is supposed to be an application-global stateless singleton, so i think you would want to fetch the disposable instance from the tool window instead.
rli
approved these changes
Jan 24, 2025
andrewyuq
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were failing perhaps due to mesasgeBus implementations missing a parentDisposable
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.