fix(amazonq): code review navigation not focusing selected issues #5326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e issues does not focus code editor to line nor show issue details
zuoyaofu
changed the title
ctlai95
reviewed
Feb 5, 2025
| } | ||
| } | ||
|
|
||
| // Move navigateToIssue as a private class function |
Contributor
Author
There was a problem hiding this comment.
oh before, the navigateToIssue was in the On double click function. This comment does not make sense anymore now. Let me delete it.
ctlai95
approved these changes
Feb 5, 2025
rli
reviewed
Feb 5, 2025
|
|
||
| showIssueDetails(issue, defaultScope) | ||
|
|
||
| synchronized(issueNode) { |
Contributor
There was a problem hiding this comment.
what exactly does the synchronized block solve?
Contributor
Author
There was a problem hiding this comment.
This was a logic transfer from the OnDoubleClick function.
My guess is that it prevents the issue from being modified (by auto scan completion which modifies the code issues or other selection?) during the execution of navigating to the line in the Editor, but I have not been able to reproduce such scenario. I left the synchronized block there just in case.
Contributor
|
/retryBuilds |
rli
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Problem:
When reviewing code issues in Amazon Q, clicking or using arrow keys to select an issue does not:
Solution:
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.