-
Notifications
You must be signed in to change notification settings - Fork 274
fix(amazonq): code review navigation not focusing selected issues #5326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b7337b1
fix(amazonq): single click or select through arrow keys on review cod…
zuoyaofu 911dd07
Merge branch 'main' into select-bug
zuoyaofu 4cce0a5
Merge branch 'main' into select-bug
zuoyaofu 915b787
add change report
zuoyaofu 10f3615
add back modelzonemarket.cs file
zuoyaofu c9ec86c
Merge branch 'main' into select-bug
zuoyaofu 506f9ba
deleted irrelevant comment
zuoyaofu 6156fbd
Merge branch 'main' into select-bug
zuoyaofu adcde1c
Merge branch 'main' into select-bug
zuoyaofu 450cbb3
Merge branch 'main' into select-bug
ctlai95 fad6638
Merge branch 'main' into select-bug
zuoyaofu 99120d6
Merge branch 'main' into select-bug
zuoyaofu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
.changes/next-release/bugfix-572380a5-32ca-490b-9a38-caf365871328.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "type" : "bugfix", | ||
| "description" : "Amazon Q /review: Unable to navigate to code location when selecting issues" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 0 additions & 53 deletions
53
...rains/services/codewhisperer/codescan/listeners/CodeWhispererCodeScanTreeMouseListener.kt
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what exactly does the synchronized block solve?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a logic transfer from the OnDoubleClick function.
My guess is that it prevents the issue from being modified (by auto scan completion which modifies the code issues or other selection?) during the execution of navigating to the line in the Editor, but I have not been able to reproduce such scenario. I left the synchronized block there just in case.