From a4e8f848ea9c76b641aea0b06fc955101d2f06df Mon Sep 17 00:00:00 2001 From: Richard Li Date: Wed, 5 Feb 2025 15:56:05 -0800 Subject: [PATCH 1/2] build: fix 251 build failure from resolving ui-tests-starter dependencies ui-tests-starter attempts to resolve the IDE distribution and fails, but it should not actually be required ro build/execute --- ui-tests-starter/build.gradle.kts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui-tests-starter/build.gradle.kts b/ui-tests-starter/build.gradle.kts index c6a4959b766..7ff1d29cce5 100644 --- a/ui-tests-starter/build.gradle.kts +++ b/ui-tests-starter/build.gradle.kts @@ -9,7 +9,7 @@ plugins { id("toolkit-kotlin-conventions") id("toolkit-intellij-plugin") - id("org.jetbrains.intellij.platform") + id("org.jetbrains.intellij.platform.module") } val ideProfile = IdeVersions.ideProfile(project) @@ -34,9 +34,7 @@ dependencies { // should really be set by the BOM, but too much work to figure out right now testImplementation("org.kodein.di:kodein-di-jvm:7.20.2") intellijPlatform { - intellijIdeaCommunity(IdeVersions.ideProfile(providers).map { it.name }) - - testFramework(TestFrameworkType.Starter) + testFramework(TestFrameworkType.Starter, ideProfile.community.sdkVersion) } testPlugins(project(":plugin-amazonq", "pluginZip")) From a9d6f9326cec486f0fa82c759e60c16b1aa98d9e Mon Sep 17 00:00:00 2001 From: Richard Li Date: Thu, 6 Feb 2025 08:41:07 -0800 Subject: [PATCH 2/2] revert --- ui-tests-starter/build.gradle.kts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ui-tests-starter/build.gradle.kts b/ui-tests-starter/build.gradle.kts index 7ff1d29cce5..32bca78feed 100644 --- a/ui-tests-starter/build.gradle.kts +++ b/ui-tests-starter/build.gradle.kts @@ -9,7 +9,7 @@ plugins { id("toolkit-kotlin-conventions") id("toolkit-intellij-plugin") - id("org.jetbrains.intellij.platform.module") + id("org.jetbrains.intellij.platform.base") } val ideProfile = IdeVersions.ideProfile(project) @@ -30,11 +30,12 @@ intellijPlatform { val testPlugins by configurations.registering dependencies { - testImplementation(platform("com.jetbrains.intellij.tools:ide-starter-squashed")) // should really be set by the BOM, but too much work to figure out right now testImplementation("org.kodein.di:kodein-di-jvm:7.20.2") intellijPlatform { - testFramework(TestFrameworkType.Starter, ideProfile.community.sdkVersion) + // shouldn't be needed? but IsolationException + intellijIdeaCommunity(ideProfile.community.sdkVersion) + testFramework(TestFrameworkType.Starter) } testPlugins(project(":plugin-amazonq", "pluginZip"))