Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Feb 6, 2025

Description

default model (no customization) should pass NULL; service will throw if arn is empty string

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner February 6, 2025 19:06
@Will-ShaoHua Will-ShaoHua changed the title fix empty string customization arn passed which causes service throwi… fix(inline): empty string customization arn (no customization selected) passed Feb 6, 2025
@Will-ShaoHua Will-ShaoHua requested review from andrewyuq and rli February 6, 2025 19:07
@Will-ShaoHua Will-ShaoHua marked this pull request as draft February 6, 2025 19:09
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review February 6, 2025 19:33
@Will-ShaoHua Will-ShaoHua removed the request for review from rli February 7, 2025 17:49
@Will-ShaoHua
Copy link
Contributor Author

/retryBuilds

@Will-ShaoHua Will-ShaoHua merged commit 1872cf7 into aws:main Feb 10, 2025
11 of 13 checks passed
@Will-ShaoHua Will-ShaoHua deleted the bug branch February 10, 2025 21:22
samgst-amazon pushed a commit that referenced this pull request Feb 12, 2025
…d) passed (#5333)

* should pass NULL if there is no selected customization
gandhi-21 pushed a commit to gandhi-21/aws-toolkit-jetbrains that referenced this pull request Feb 26, 2025
…d) passed (aws#5333)

* should pass NULL if there is no selected customization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants