From a8a5d8e3c474ca7a5cffa68beeb0c64fe309b5f0 Mon Sep 17 00:00:00 2001 From: Will Lo Date: Mon, 10 Feb 2025 09:09:20 -0800 Subject: [PATCH] fix infinite service call of sendUserModification on failure --- .../telemetry/CodeWhispererUserModificationTracker.kt | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererUserModificationTracker.kt b/plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererUserModificationTracker.kt index b5ce5048c4a..7b4e911138b 100644 --- a/plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererUserModificationTracker.kt +++ b/plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererUserModificationTracker.kt @@ -135,7 +135,7 @@ class CodeWhispererUserModificationTracker(private val project: Project) : Dispo } private fun emitTelemetryOnChatCodeInsert(insertedCode: InsertedCodeModificationEntry) { - try { + val modificationPercentage = try { val file = insertedCode.vFile if (file == null || (!file.isValid)) throw Exception("Record OnChatCodeInsert - invalid file") @@ -145,11 +145,12 @@ class CodeWhispererUserModificationTracker(private val project: Project) : Dispo val currentString = document?.getText( TextRange(insertedCode.range.startOffset, insertedCode.range.endOffset) ) - val modificationPercentage = checkDiff(currentString?.trim(), insertedCode.originalString.trim()) - sendModificationWithChatTelemetry(insertedCode, modificationPercentage) + checkDiff(currentString?.trim(), insertedCode.originalString.trim()) } catch (e: Exception) { - sendModificationWithChatTelemetry(insertedCode, null) + null } + + sendModificationWithChatTelemetry(insertedCode, modificationPercentage) } private fun emitTelemetryOnSuggestion(acceptedSuggestion: AcceptedSuggestionEntry) {