Skip to content

feat(amazonq): Added changes for override lsp artifacts #5429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 6, 2025
Merged

feat(amazonq): Added changes for override lsp artifacts #5429

merged 16 commits into from
Mar 6, 2025

Conversation

@LokeshDogga13
Copy link
Contributor

@LokeshDogga13 LokeshDogga13 commented Mar 3, 2025 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

When user want to override existing LSP artifacts this method will help them to select the corresponding JS file.
image

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LokeshDogga13 LokeshDogga13 requested a review from a team as a code owner March 3, 2025 17:06
@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

Qodana Community for JVM

2 new problems were found

Inspection name Severity Problems
Usage of redundant or deprecated syntax or deprecated symbols 🔶 Warning 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@LokeshDogga13
Copy link
Contributor Author

LokeshDogga13 commented Mar 3, 2025

/retryBuilds

@LokeshDogga13 LokeshDogga13 requested a review from a team as a code owner March 4, 2025 00:25
@LokeshDogga13
Copy link
Contributor Author

LokeshDogga13 commented Mar 4, 2025

/retryBuilds

@LokeshDogga13 LokeshDogga13 enabled auto-merge (squash) March 5, 2025 18:55
@LokeshDogga13 LokeshDogga13 requested a review from rli March 5, 2025 23:56
@rli rli disabled auto-merge March 6, 2025 16:58
@rli rli merged commit 84b0f7d into feature/q-lsp Mar 6, 2025
15 of 18 checks passed
@rli rli deleted the lodogga/overrideLSPArtifacts branch March 6, 2025 16:58
@rli rli mentioned this pull request Mar 6, 2025
Merged
rli added a commit that referenced this pull request Mar 7, 2025
@rli
feat(amazonq): launch lsp from resolved artifacts and allow user to o…
b6ae7b1 
…verride via config (#5449)

download implemented in #5387
override UI implemented in #5429

Additionally, use zipfs for extracting zip files to respect original posix attributes on systems where that is relevant
leigaol pushed a commit to leigaol/aws-toolkit-jetbrains that referenced this pull request Mar 20, 2025
@LokeshDogga13 @leigaol
feat(amazonq): Added changes for override lsp artifacts (aws#5429)
30cde06
leigaol pushed a commit to leigaol/aws-toolkit-jetbrains that referenced this pull request Mar 20, 2025
@rli @leigaol
feat(amazonq): launch lsp from resolved artifacts and allow user to o…
f25a2fe 
…verride via config (aws#5449)

download implemented in aws#5387
override UI implemented in aws#5429

Additionally, use zipfs for extracting zip files to respect original posix attributes on systems where that is relevant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rli rli rli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LokeshDogga13 @rli